From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4A65B268DC for ; Fri, 9 Aug 2019 11:46:57 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4nx_IQzxOPfP for ; Fri, 9 Aug 2019 11:46:57 -0400 (EDT) Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 09B5325CBE for ; Fri, 9 Aug 2019 11:46:56 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: [tarantool-patches] Re: [PATCH] sql: remove unused mask From: "n.pettik" In-Reply-To: <20190802124629.54302-1-roman.habibov@tarantool.org> Date: Fri, 9 Aug 2019 18:46:54 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20190802124629.54302-1-roman.habibov@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Roman Khabibov > On 2 Aug 2019, at 15:46, Roman Khabibov = wrote: >=20 > Field mask of "struct Keyword" is always set to one not null > macroses and used only once for checking that it isn't null. So, > the field should be removed. >=20 > Closes #4155 I=E2=80=99ve fixed commit message and force pushed. sql: remove mask from struct Keyword =20 Originally, mask in struct Keyword served to reduce set of reserved keywords for build-dependent features. For instance, it was allowed = to disable triggers as a compilation option, and in this case TRIGGER wouldn't be reserved word. Nowadays, our build always comprises all features, so there's no need in this option anymore. Hence, we can remove mask alongside with related to it macros. =20 Closes #4155 The rest is OK as obvious.=