From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2B5476F3C7; Fri, 26 Mar 2021 17:54:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2B5476F3C7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616770461; bh=waGBcowKkpm+6VXZk9SzZ+8aGd1nOL3BLAwZkWWgZqg=; h=In-Reply-To:Date:References:To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=I1bQNPEQHEGshc6wi/IBQwTyukYGtM34b1CRQL+wp8rp7AoG9dAdbU4j7xc3Rq+2m 2PJzmkgctICDx7pbvDrcqqirrgbJ+mdoGTuToBNhx0QjfaXqAOFrk9uxdJes8y5pJS gbigWj+h8SFY/yo+QROMkKRxoXsPsXwPeQu5lOZg= Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [94.100.177.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D83656F3C7 for ; Fri, 26 Mar 2021 17:54:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D83656F3C7 Received: by smtp44.i.mail.ru with esmtpa (envelope-from ) id 1lPnqt-0006fo-7p; Fri, 26 Mar 2021 17:54:19 +0300 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) In-Reply-To: Date: Fri, 26 Mar 2021 17:54:18 +0300 Content-Transfer-Encoding: 7bit Message-Id: References: To: Sergey Kaplun X-Mailer: Apple Mail (2.3654.60.0.2.21) X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E3294CA3588DDE0233B0D17711AF1EA2D7DB9182A05F538085040B3C75C08CD2B6FE6006C1AF2BEF7301C09908CE7CBFE21114972D7B5442C357A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DB84ED444C624799EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E25DEE08FA4D750E8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C5DD32608FC869F5D72511813F820166CB9B82FE71EAA50C9A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE767883B903EA3BAEA9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C362968DCAA3E4B45B117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E7352629B07FD02F83A6C4224003CC83647689D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C978310E30CAC7386D4B3067D7C3C64BB55547 X-C1DE0DAB: 0D63561A33F958A55EE5B2AE27D177E9152FA148E814E92E762373E60FCDA8BDD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D343F22CE0A71FDB37E50A8304BC39AE5FA8658C4D2623C2CE4FAA948701134AB8F6DF3DFB2274227E61D7E09C32AA3244C06EC9D884BCEC9B4109F4616FE2194CE8894E9C85370243EFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojapPp7P/VpAgIVHAauuf8Dg== X-Mailru-Sender: 3B9A0136629DC912F4AABCEFC589C81E6E189C70713E92D4AF637C0C2BBB26B43F87A915DA423B2AAD07DD1419AC565FA614486B47F28B67C5E079CCF3B0523AED31B7EB2E253A9E112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 15/30] test: disable PUC-Lua test for per-coroutine hooks X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Ostanevich via Tarantool-patches Reply-To: Sergey Ostanevich Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" LGTM. Sergos > On 26 Mar 2021, at 10:42, Sergey Kaplun wrote: > > LuaJIT does not support per-coroutine hooks. > See actual status at https://luajit.org/status.html. > > This patch disables tests for per-coroutine hooks in . > > Part of tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > --- > test/PUC-Lua-5.1-tests/db.lua | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/test/PUC-Lua-5.1-tests/db.lua b/test/PUC-Lua-5.1-tests/db.lua > index c704877..8ea6af7 100644 > --- a/test/PUC-Lua-5.1-tests/db.lua > +++ b/test/PUC-Lua-5.1-tests/db.lua > @@ -511,8 +511,11 @@ a,b = debug.getlocal(co, 1, 2) > assert(a == "a" and b == 1) > debug.setlocal(co, 1, 2, "hi") > assert(debug.gethook(co) == foo) > -assert(table.getn(tr) == 2 and > - tr[1] == l.currentline-1 and tr[2] == l.currentline) > +-- LuaJIT does not support per-coroutine hooks. > +-- See also https://luajit.org/status.html. > +-- LuaJIT: Test is disabled for LuaJIT. > +-- assert(table.getn(tr) == 2 and > +-- tr[1] == l.currentline-1 and tr[2] == l.currentline) > > a,b,c = pcall(coroutine.resume, co) > assert(a and b and c == l.currentline+1) > @@ -520,9 +523,13 @@ checktraceback(co, {"yield", "in function <"}) > > a,b = coroutine.resume(co) > assert(a and b == "hi") > -assert(table.getn(tr) == 4 and tr[4] == l.currentline+2) > +-- Behavior is different for LuaJIT. See the comment above. > +-- LuaJIT: Test is disabled for LuaJIT. > +-- assert(table.getn(tr) == 4 and tr[4] == l.currentline+2) > assert(debug.gethook(co) == foo) > -assert(debug.gethook() == nil) > +-- Behavior is different for LuaJIT. See the comment above. > +-- LuaJIT: Test is disabled for LuaJIT. > +-- assert(debug.gethook() == nil) > checktraceback(co, {}) > > > -- > 2.31.0 >