From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 071352B656 for ; Wed, 4 Apr 2018 07:30:39 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2hS0tcRufxgO for ; Wed, 4 Apr 2018 07:30:38 -0400 (EDT) Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [94.100.177.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3BAE12B653 for ; Wed, 4 Apr 2018 07:30:37 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: [tarantool-patches] Re: [PATCH 2/4] sql: remove unused error codes, use enum instead of defines From: "n.pettik" In-Reply-To: <64bd8cfd-48ec-1171-d58e-94779d17b3f9@tarantool.org> Date: Wed, 4 Apr 2018 14:30:34 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: References: <3FC50B7F-FE28-4F8C-A79C-C287FD6EA1CB@tarantool.org> <64bd8cfd-48ec-1171-d58e-94779d17b3f9@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Vladislav Shpilevoy Ack. > On 4 Apr 2018, at 13:26, Vladislav Shpilevoy = wrote: >=20 >> I do like move to enum, but what about removing this obsolete = =E2=80=99SQLITE=E2=80=99 prefix? >> Let it be just =E2=80=99SQL_=E2=80=99. Moreover, some error seems to = be SQLite specific. >> Great time to remove them, isn=E2=80=99t it? >> If you don=E2=80=99t want or don=E2=80=99t have time for this boring = routine, you can create issue >> with =E2=80=98good first issue=E2=80=99 label. > I am afraid that a diff will be huge, if a rename SQLITE_OK, for = example. Lets do it later, when more > source code and error codes will be removed. > https://github.com/tarantool/tarantool/issues/3315 >=20 > Please, review the huge diff below very carefully. I could make a = mistake here. >=20 > diff --git a/src/box/sql/vdbeInt.h b/src/box/sql/vdbeInt.h > index f8f4e566b..6ea8c91d7 100644 > --- a/src/box/sql/vdbeInt.h > +++ b/src/box/sql/vdbeInt.h > @@ -442,7 +442,6 @@ struct Vdbe { > int nScan; /* Entries in aScan[] */ > ScanStatus *aScan; /* Scan definitions for = sqlite3_stmt_scanstatus() */ > #endif > - > }; >=20 > /* >=20 >=20 >=20