From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Serge Petrenko Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_1FABA3A7-3F5D-40BE-900E-6172F499C616" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [tarantool-patches] [PATCH] Extend range of printable unicode characters Date: Wed, 17 Jul 2019 12:00:36 +0300 In-Reply-To: <20190716183157.GB19727@atlas> References: <20190716134331.15327-1-sergepetrenko@tarantool.org> <20190716183157.GB19727@atlas> To: Konstantin Osipov Cc: tarantool-patches@freelists.org, Vladimir Davydov , alexander.turenko@tarantool.org List-ID: --Apple-Mail=_1FABA3A7-3F5D-40BE-900E-6172F499C616 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > 16 =D0=B8=D1=8E=D0=BB=D1=8F 2019 =D0=B3., =D0=B2 21:31, Konstantin = Osipov =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0= =B0): >=20 > * Serge Petrenko [19/07/16 16:44]: >> Before the patch IS_PRINTABLE macros was used >> to determine if given character is printable or not. >> This macros did not take into account characters >> encoded with 4 bytes. >> After the patch IS_PRINTABLE is replaced with new >> corresponding function. Now the range of printable >> characters is: (libyaml old range) U (icu range). This >> new range include characters encoded with 4 bytes. >>=20 >=20 > Please don't forget to upstream the patch to the maintainer once > it's reviewed. Ok >=20 > Has there been any changes in the upstream which we should be > aware of? None that I=E2=80=99m aware of. Similar issues are still open in the libyaml repo. https://github.com/yaml/libyaml/issues/110 = The code dealing with printable unicode characters in libyaml remains the same, it doesn=E2=80=99t deal with codepoints outside of the Basic Multilingual Plane (every code point > 0xFFFF) https://github.com/yaml/libyaml/blob/master/src/yaml_private.h#L261 >=20 > On another note, since we're switching to Lua emitter as the > defualt one quite soon, we can perhaps close #4090 as won't fix > rather than bother improving libyaml. >=20 >> Related to tarantool/tarantool#4090 >=20 > --=20 > Konstantin Osipov, Moscow, Russia -- Serge Petrenko sergepetrenko@tarantool.org --Apple-Mail=_1FABA3A7-3F5D-40BE-900E-6172F499C616 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8



16 =D0=B8=D1=8E=D0=BB=D1=8F 2019 =D0=B3., =D0=B2 21:31, = Konstantin Osipov <kostja@tarantool.org> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0= =D0=BB(=D0=B0):

* Serge Petrenko <sergepetrenko@tarantool.org> [19/07/16 16:44]:
Before the patch = IS_PRINTABLE macros was used
to determine if given = character is printable or not.
This macros did not take = into account characters
encoded with 4 bytes.
After the patch IS_PRINTABLE is replaced with new
corresponding function. Now the range of printable
characters is: (libyaml old range) U (icu range). This
new range include characters encoded with 4 bytes.


Please don't = forget to upstream the patch to the maintainer once
it's = reviewed.

Ok


Has there been = any changes in the upstream which we should be
aware = of?

None that I=E2=80=99m aware of.
Similar = issues are still open in the libyaml repo.
The = code dealing with printable unicode characters in = libyaml
remains the same, it doesn=E2=80=99t deal with = codepoints outside of
the Basic Multilingual Plane (every code = point > 0xFFFF)




On another note, since we're switching to Lua = emitter as the
defualt one quite soon, we can perhaps = close #4090 as won't fix
rather than bother improving = libyaml.

Related to tarantool/tarantool#4090

--
Konstantin = Osipov, Moscow, Russia


= --Apple-Mail=_1FABA3A7-3F5D-40BE-900E-6172F499C616--