From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A01E724EF0 for ; Fri, 11 May 2018 09:12:45 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bS63ZKX9JrgB for ; Fri, 11 May 2018 09:12:45 -0400 (EDT) Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 4F01924E0A for ; Fri, 11 May 2018 09:12:44 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: Tests for CREATE TEMP TABLE and CREATE TEMPORARY TABLE From: "n.pettik" In-Reply-To: <6369401525886435@web18j.yandex.ru> Date: Fri, 11 May 2018 16:12:42 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: References: <2050311525824390@web59j.yandex.ru> <225ED31B-14F7-4BF1-9383-2100722DFEF2@tarantool.org> <6369401525886435@web18j.yandex.ru> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: roman.habibov1@yandex.ru Don=E2=80=99t hurry when preparing patch or making fixes. Remember: =E2=80=98haste makes waste=E2=80=99. >> Please, read guidelines carefully. >>=20 >>> sql: Tests for CREATE TEMP TABLE and CREATE TEMPORARY TABLE >>=20 >> According to our docs: >> =E2=80=94 2. Try to limit the subject line to 50 characters or so. >> =E2=80=94 3. Start the subject line with a capital letter unless it = prefixed with a subsystem name and semicolon=E2=80=A6 > Sorry. I fixed that. No, you didn=E2=80=99t. Read it again. I see old violations on your = branch. >There is exeptions, when these clauses are used. Typo: =E2=80=99there are=E2=80=99. Use some spell-checker or whatever. Rephrase whole sentence: it seems to be misleading. >> I would also add tests (or just rewrite yours) which check that = complete CREATE TABLE statement doesn=E2=80=99t support TEMP clause: >>=20 >> CREATE TEMP TABLE t1(=E2=80=A6); >>=20 >> CREATE TEMPORARY TABLE t1(=E2=80=A6); > + CREATE TEMP TABLE t1(); > + CREATE TEMPORARY TABLE t1(); Cmon, use complete form of CREATE TABLE statement. You can=E2=80=99t create table with no columns.=