From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 6308F2D1EF for ; Wed, 11 Apr 2018 15:32:26 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0nHU_vS8layt for ; Wed, 11 Apr 2018 15:32:26 -0400 (EDT) Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C18A42D199 for ; Wed, 11 Apr 2018 15:32:25 -0400 (EDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: [tarantool-patches] Re: [PATCH] sql: remove unnecessary MakeRecord opcodes From: "n.pettik" In-Reply-To: <20180404123813.93961-1-niatshin@tarantool.org> Date: Wed, 11 Apr 2018 22:32:22 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20180404123813.93961-1-niatshin@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Bulat Niatshin Cc: tarantool-patches@freelists.org Hello. Only minor remark concerning commit message. Rephrase it little bit, please. Lets mention, that you are saying about bytecode which is generated to process constraint checks. > On 4 Apr 2018, at 15:38, Bulat Niatshin = wrote: >=20 > OP_MakeRecord creates a record from a given range of registers > and stores that record in a specified register. This is obvious and can be dropped. > But now even > secondary indexes with non-default ON CONFLICT clause doesn't > need it, Good place to explain why. > it is necessary only for primary key indexes. However > that unnecesary opcodes appear in INSERT listings. This patch > contains a fix for that. >=20 > Closes #3317 > --- > src/box/sql/insert.c | 16 ++++------------ > 1 file changed, 4 insertions(+), 12 deletions(-) >=20 > diff --git a/src/box/sql/insert.c b/src/box/sql/insert.c > index 4a57b23f5..701fae412 100644 > --- a/src/box/sql/insert.c > +++ b/src/box/sql/insert.c > @@ -1309,18 +1309,10 @@ sqlite3GenerateConstraintChecks(Parse * = pParse, /* The parser context */ > sqlite3VdbeResolveLabel(v, = skip_if_null); > } > } > - if (IsPrimaryKeyIndex(pIdx) || = uniqueByteCodeNeeded) { > - sqlite3VdbeAddOp3(v, OP_MakeRecord, = regNewData + 1, > - pTab->nCol, = aRegIdx[ix]); > - VdbeComment((v, "for %s", pIdx->zName)); > - } > - } else { > - /* kyukhin: for Tarantool, this should be = evaluated to NOP. */ > - if (IsPrimaryKeyIndex(pIdx) || = uniqueByteCodeNeeded) { > - sqlite3VdbeAddOp3(v, OP_MakeRecord, = regIdx, > - nIdxCol, aRegIdx[ix]); > - VdbeComment((v, "for %s", pIdx->zName)); > - } > + > + sqlite3VdbeAddOp3(v, OP_MakeRecord, regNewData + = 1, > + pTab->nCol, aRegIdx[ix]); > + VdbeComment((v, "for %s", pIdx->zName)); > } >=20 > /* In an UPDATE operation, if this index is the PRIMARY = KEY > --=20 > 2.14.1 >=20