From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <roman.habibov@tarantool.org>
Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 014534696C3
 for <tarantool-patches@dev.tarantool.org>;
 Fri,  3 Apr 2020 20:40:18 +0300 (MSK)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3594.4.19\))
From: Roman Khabibov <roman.habibov@tarantool.org>
In-Reply-To: <20200403152752.8923-1-roman.habibov@tarantool.org>
Date: Fri, 3 Apr 2020 20:40:16 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <BCDB5519-76F1-4AE5-9550-6D9C6C2A0D7E@tarantool.org>
References: <20200403152752.8923-1-roman.habibov@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 0/2] Support column addition with
 <ALTER TABLE>
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: tarantool-patches@dev.tarantool.org
Cc: v.shpilevoy@tarantool.org

Oops. I hurry up.  Done, now I have created a template document.
This is the last time.

@Changelog
- Add ability to add a column to a space with <ALTER TABLE ADD COLUMN>.

Branch: =
https://github.com/tarantool/tarantool/tree/romanhabibov/gh-3075-add-colum=
n-v2
Issue: https://github.com/tarantool/tarantool/issues/3075,
https://github.com/tarantool/tarantool/issues/2349

> On Apr 3, 2020, at 18:27, Roman Khabibov <roman.habibov@tarantool.org> =
wrote:
>=20
> According to the SQL standard, column definition in a
> <CREATE TABLE> and a <ALTER TABLE ADD COLUMN> is the same. So, I
> decided to support Tarantool features like AUTOINCREMENT in the
> alter column description.
>=20
> Roman Khabibov (2):
>  sql: rename TK_COLUMN to TK_COLUMN_NAME
>  sql: support column addition
>=20
> extra/addopcodes.sh          |   2 +-
> extra/mkkeywordhash.c        |   5 +-
> src/box/errcode.h            |   2 +
> src/box/schema_def.h         |   1 +
> src/box/sql/alter.c          |   1 +
> src/box/sql/build.c          | 596 +++++++++++++++++++++++------------
> src/box/sql/expr.c           |  42 +--
> src/box/sql/fk_constraint.c  |   2 +-
> src/box/sql/parse.y          |  45 ++-
> src/box/sql/parse_def.h      |  62 ++--
> src/box/sql/prepare.c        |   8 +-
> src/box/sql/resolve.c        |  10 +-
> src/box/sql/select.c         |  10 +-
> src/box/sql/sqlInt.h         |  58 +++-
> src/box/sql/treeview.c       |   2 +-
> src/box/sql/where.c          |  18 +-
> src/box/sql/whereexpr.c      |  12 +-
> test/box/error.result        |   2 +
> test/sql/add-column.result   | 231 ++++++++++++++
> test/sql/add-column.test.lua |  87 +++++
> 20 files changed, 892 insertions(+), 304 deletions(-)
> create mode 100644 test/sql/add-column.result
> create mode 100644 test/sql/add-column.test.lua
>=20
> --=20
> 2.21.0 (Apple Git-122)
>=20