From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 9999322F71 for ; Tue, 8 May 2018 06:30:44 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OqZasC_ETJ39 for ; Tue, 8 May 2018 06:30:44 -0400 (EDT) Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id D297C228B4 for ; Tue, 8 May 2018 06:30:43 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: [tarantool-patches] Re: [PATCH v1 1/1] Tests for CREATE TEMP TABLE and CREATE TEMPORARY TABLE From: "n.pettik" In-Reply-To: Date: Tue, 8 May 2018 13:30:38 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: References: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: roman.habibov1@yandex.ru Hello, Roman. Firstly, please specify subject of commit. In your particular case, test definitely belongs to SQL part of project, so it is better to write 'sql: Tests for CREATE TEMP TABLE and CREATE TEMPORARY TABLE'. Notice, that commit subject should fit into 50 chars lenght. Read this guide: = https://tarantool.io/en/doc/2.0/dev_guide/developer_guidelines.html#how-to= -write-a-commit-message Secondly, after '---' delimiter (which separates commit message and body of the patch) put link to your branch and corresponding issue. Read this: = https://tarantool.io/en/doc/2.0/dev_guide/developer_guidelines.html#how-to= -submit-a-patch-for-review Then, don't spam with commits. If you are willing to update your remote branch with new version of the same code, use 'force' option: git push -f. As for your patch, it must consist of only 1 commit. Please, update your branch so than I can take a loot at whole patch. >+-- gh-2166 Functions with TEMP and TEMPORARY was removed before. Typo: =E2=80=98were=E2=80=99. And not functions, but tables themselves, = I guess.