From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BE28027EE02; Thu, 2 Feb 2023 10:01:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BE28027EE02 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1675321283; bh=cL/BHXxVWJ6JGl5RKU6BYBaZA2g00vQxfxDCn1aY3oo=; h=In-Reply-To:Date:References:To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=CmKMzPRgUAiDbFBd2Z3t7V40ppFKSqKwzSRLD9Dgm75fYL8LgXfL4TnIiMhMLorGB 1LZnH+lWzoCYOkw63DnHb2YZLI2ahXx2Sa4sqk+UIHq1LxuqlJ01VRFx04+iXAGGeG D5V7LNRw5J9ep6japtdxxaNbjm63tlGhkS+kmNu0= Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 33D2F209901 for ; Thu, 2 Feb 2023 10:01:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 33D2F209901 Received: by smtp56.i.mail.ru with esmtpa (envelope-from ) id 1pNTaz-0002jf-AJ; Thu, 02 Feb 2023 10:01:21 +0300 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) In-Reply-To: <20230119162329.31893-1-skaplun@tarantool.org> Date: Thu, 2 Feb 2023 10:01:10 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20230119162329.31893-1-skaplun@tarantool.org> To: Sergey Kaplun X-Mailer: Apple Mail (2.3731.300.101.1.3) X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9AD83B49AC1DDA08967EC36FA2B240E0E9DA1CCEB7D38F385182A05F5380850404C228DA9ACA6FE27A027A009BB3D63618A8A81A072AB4B2831B5B050FCBA780A5E99471DBCDBABDD X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE79FF7180C05A1FF7CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006371895637A5F0B45FF8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D849F8B2CA413429EE996E7AD38B47DE82117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520437C869540D2AB0F28451B159A507268D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE4B6963042765DA4BE21AE983DBD7FFC1D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE32A336C65186350916E0066C2D8992A16C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637AD0424077D726551EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34BF5454112BD5BFD713399E4C6A5EB83EA4DADCAB8234A7DB61B8DF358B8B8AB8EA55F1C58AA156901D7E09C32AA3244CBBC04346CBB7231DC54CDD916E4538A2B4DF56057A86259FFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojUCXb8yEWKAmrG5mXGKbxNQ== X-Mailru-Sender: 5AA3D5B9D8C486465A7E7C46D91E24B0932F12EF27A7E1558A8A81A072AB4B28E8285F0AB37D98A760D8632BEC246C7D55B4A2144138A8805FC805B5969CB4993EE16157CC7DAB4272D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: add test for `string.char('%c', 0)` X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: sergos via Tarantool-patches Reply-To: sergos Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! LGTM with fixes proposed by Max. Sergos > On 19 Jan 2023, at 19:23, Sergey Kaplun wrote: >=20 > This patch adds the test for the commit > 430d9f8f7ebb779948dbd43944b876b1a3f58551 ("Fix string.format("%c", > 0)."). Although, the issue affects 2.0 branch only, there is no need = to > fix it. Nevertheless, the test is required to avoid regressions in the > future. >=20 > Part of tarantool/tarantool#8069 > --- >=20 > PR: https://github.com/tarantool/tarantool/pull/8189 > Branch: = https://github.com/tarantool/luajit/tree/skaplun/lj-378-string-format-c-nu= ll-char-full-ci > Issues: > * https://github.com/tarantool/tarantool/issues/8069 > * https://github.com/LuaJIT/LuaJIT/issues/378 >=20 > .../lj-378-string-format-c-null-char.test.lua | 11 +++++++++++ > 1 file changed, 11 insertions(+) > create mode 100644 = test/tarantool-tests/lj-378-string-format-c-null-char.test.lua >=20 > diff --git = a/test/tarantool-tests/lj-378-string-format-c-null-char.test.lua = b/test/tarantool-tests/lj-378-string-format-c-null-char.test.lua > new file mode 100644 > index 00000000..15cefadf > --- /dev/null > +++ b/test/tarantool-tests/lj-378-string-format-c-null-char.test.lua > @@ -0,0 +1,11 @@ > +local tap =3D require('tap') > + > +local test =3D tap.test('lj-378-string-format-c-null-char') > +test:plan(1) > + > +-- Test file to check that there is no regression in > +-- `string.format('%c', 0)` behaviour. > +-- See also https://github.com/LuaJIT/LuaJIT/issues/378. > + > +test:is(string.format('%c', 0), '\0', 'string.format %c on null = char') > +os.exit(test:check() and 0 or 1) > --=20 > 2.34.1 >=20