From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 743536F3C7; Fri, 26 Mar 2021 18:44:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 743536F3C7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616773479; bh=J8OwEG+TEUdkkFWsJcwlv+CgB0DFMNIdlpof5wRKsrQ=; h=In-Reply-To:Date:References:To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Mop8Tm7PHpo4HvsAHUZfprj3FQJIbz8BeqqapvgZhCof60si66tBopRxyNCp9B+IV hYvj17OtUMN4vWmG/wO+OXf7N9xKLxJuEEMcrQQMos2ziwaniRdVAI5nIGNlM6XrK/ r/SLgRfllJXXaCHpwdEdNaHq6EaKZr9azv1Yk/LI= Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D1F296F3C7 for ; Fri, 26 Mar 2021 18:44:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D1F296F3C7 Received: by smtp40.i.mail.ru with esmtpa (envelope-from ) id 1lPoda-0001Ob-2S; Fri, 26 Mar 2021 18:44:38 +0300 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) In-Reply-To: Date: Fri, 26 Mar 2021 18:44:37 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Sergey Kaplun X-Mailer: Apple Mail (2.3654.60.0.2.21) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E3294DD38BE31D7797EF84C856624A09E4809182A05F53808504031BC34BC8E760877B062F6EA8DB4B5AA063A7187DA07127F4C5A44B57EA62DCC X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78CB87876C5D626D4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063702DFA59B3C994360EA1F7E6F0F101C67CDEEF6D7F21E0D1D174C73DBBBFC7664183FC4D1B98D6C0339C40EB2AF16B82851A4D27312FD4F50389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B64854413538E1713FCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C224937681D504217FE8376E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8B8DF2389163BEC5C23AA81AA40904B5D9DBF02ECDB25306B2201CA6A4E26CD07C3BBE47FD9DD3FB595F5C1EE8F4F765FCA83251EDC214901ED5E8D9A59859A8B682BBBAF5DF00056E089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5554ADF4B72C131D608FF9B780D883665F8A1C88C721C3E77D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D346840168BCAD8054EAC214FA576F99E55AF51D006982DBC65E38D6D6C422B1F92B6C07ED8C38CA18A1D7E09C32AA3244C28EAA6F451540B195E37B98565482CD3FE8DA44ABE2443F7FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojapPp7P/VpAggwjIGa1OZPQ== X-Mailru-Sender: 455D65AE3A139168626D8C76E86D3AC0061654E72CCF8979BB648A11E1110B56DDAC019A3742A8B676D79013C85012CDC77752E0C033A69E4BBE7EBD99111A499D0AB74157175C036C18EFA0BB12DBB0 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 22/30] test: disable PUC Lua test for var names in error X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Ostanevich via Tarantool-patches Reply-To: Sergey Ostanevich Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Nit in message, LGTM. Sergos > On 26 Mar 2021, at 10:43, Sergey Kaplun wrote: >=20 > LuaJIT includes variable name to the error report, when try to > call non-function object without __call methamethod. > Also, LuaJIT includes variable name to the error report, when try to > perform unacceptable arifmetic operation with the variable. arithmetic > Lua 5.1 doesn't report variable name in these errors. >=20 > Test ckecked that variable name aren't reported are disabled by > this patch. >=20 > Part of tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > --- > test/PUC-Lua-5.1-tests/errors.lua | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) >=20 > diff --git a/test/PUC-Lua-5.1-tests/errors.lua = b/test/PUC-Lua-5.1-tests/errors.lua > index e881211..cf24e40 100644 > --- a/test/PUC-Lua-5.1-tests/errors.lua > +++ b/test/PUC-Lua-5.1-tests/errors.lua > @@ -72,8 +72,13 @@ checkmessage("b=3D1; local aaa=3D'a'; x=3Daaa+b", = "local 'aaa'") > checkmessage("aaa=3D{}; x=3D3/aaa", "global 'aaa'") > checkmessage("aaa=3D'2'; b=3Dnil;x=3Daaa*b", "global 'b'") > checkmessage("aaa=3D{}; x=3D-aaa", "global 'aaa'") > -assert(not string.find(doit"aaa=3D{}; x=3D(aaa or aaa)+(aaa and = aaa)", "'aaa'")) > -assert(not string.find(doit"aaa=3D{}; (aaa or aaa)()", "'aaa'")) > +-- LuaJIT: LuaJIT includes variable name to the error report. > +-- It looks like: > +-- "attempt to perform arithmetic on global 'aaa' (a table value)" > +-- Lua 5.1 doesn't report variable name here. > +-- Tests are disabled for LuaJIT. > +-- assert(not string.find(doit"aaa=3D{}; x=3D(aaa or aaa)+(aaa and = aaa)", "'aaa'")) > +-- assert(not string.find(doit"aaa=3D{}; (aaa or aaa)()", "'aaa'")) >=20 > checkmessage([[aaa=3D9 > repeat until 3=3D=3D3 > --=20 > 2.31.0 >=20