From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 682E74696C3 for ; Fri, 3 Apr 2020 17:02:35 +0300 (MSK) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) From: Chris Sosnin In-Reply-To: <20200403130923.GC2993@tarantool.org> Date: Fri, 3 Apr 2020 17:02:33 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20200403130923.GC2993@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 0/4] session settings fixes List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikita Pettik Cc: tarantool-patches@dev.tarantool.org It was v2, Vlad asked me to resend the whole patchset for=20 convenience. Won=E2=80=99t forget to do this next time. > On 3 Apr 2020, at 16:09, Nikita Pettik wrote: >=20 > On 30 Mar 12:13, Chris Sosnin wrote: >> issue #1:https://github.com/tarantool/tarantool/issues/4711 >> issue #2:https://github.com/tarantool/tarantool/issues/4712 >> = branch:https://github.com/tarantool/tarantool/tree/ksosnin/gh-4712-session= -settings-v2 >=20 > Nit: while sending next version of patch-set please specify it > explicitly with --subject-prefix=3D'PATCH v2' and attach changelog > between versions. For example: = https://lists.tarantool.org/pipermail/tarantool-patches/2020-March/015103.= html >=20 >> Chris Sosnin (4): >> box: replace session_settings modules with a single array >> box: add binary search for _session_settings space >> box: provide a user friendly frontend for accessing session settings >> sql: provide a user friendly frontend for accessing session settings >>=20 >> extra/mkkeywordhash.c | 1 + >> src/box/lua/session.c | 111 +++++++++ >> src/box/session.cc | 1 + >> src/box/session.h | 2 + >> src/box/session_settings.c | 214 = +++++++++++------- >> src/box/session_settings.h | 53 +++-- >> src/box/sql.c | 5 - >> src/box/sql/build.c | 104 ++++----- >> src/box/sql/parse.y | 5 + >> src/box/sql/sqlInt.h | 11 + >> src/box/sql/vdbe.c | 50 ++++ >> ...rontend.result =3D> session_settings.result} | 147 ++++++++++-- >> ...end.test.lua =3D> session_settings.test.lua} | 61 ++++- >> 13 files changed, 589 insertions(+), 176 deletions(-) >> rename test/box/{gh-4511-access-settings-from-any-frontend.result =3D> = session_settings.result} (71%) >> rename test/box/{gh-4511-access-settings-from-any-frontend.test.lua = =3D> session_settings.test.lua} (64%) >>=20 >> --=20 >> 2.21.1 (Apple Git-122.3) >>=20