From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <roman.habibov@tarantool.org>
Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id A205E469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu,  8 Oct 2020 13:32:25 +0300 (MSK)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\))
From: Roman Khabibov <roman.habibov@tarantool.org>
In-Reply-To: <d4496e19-636b-a8b1-459b-7231ed9e18a7@tarantool.org>
Date: Thu, 8 Oct 2020 13:32:23 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <B1A8AB35-D65A-4F92-9AAA-0EA6DFC98552@tarantool.org>
References: <20200911215115.6622-1-roman.habibov@tarantool.org>
 <20200911215115.6622-3-roman.habibov@tarantool.org>
 <36bb1beb-a59a-57d9-a1ef-c0ef5af49d35@tarantool.org>
 <F65D415F-203D-486C-A825-E0D11893EC6F@tarantool.org>
 <d8f137c3-ac15-1c02-7fbc-690aa1972e92@tarantool.org>
 <F1CE04A0-ACB8-4F11-91A9-2FE5CC2270E7@tarantool.org>
 <f8722e8a-0f7a-9d75-a423-76b0d8e6f5e1@tarantool.org>
 <69305126-34BC-41B8-B209-4D7C3BE30BC2@tarantool.org>
 <d4496e19-636b-a8b1-459b-7231ed9e18a7@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4 2/6] sql: refactor
 create_table_def and parse
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi!

> On Oct 8, 2020, at 01:35, Vladislav Shpilevoy =
<v.shpilevoy@tarantool.org> wrote:
>=20
> Hi! Thanks for the answer!
>=20
>>>> diff --git a/src/box/sql/parse_def.h b/src/box/sql/parse_def.h
>>>> index cb0ecd2fc..21829b6f0 100644
>>>> --- a/src/box/sql/parse_def.h
>>>> +++ b/src/box/sql/parse_def.h
>>>> @@ -500,12 +505,12 @@ create_view_def_init(struct create_view_def =
*view_def, struct Token *name,
>>>> }
>>>>=20
>>>> static inline void
>>>> -create_table_def_destroy(struct create_table_def *table_def)
>>>> +create_fkeys_def_destroy(struct create_fkeys_def *fkeys_def)
>>>=20
>>> Where is create_checks_def destroyed?
>> There's nothing to destroy in create_checks_def. Or is it worth
>> creating it to keep the formality?
>=20
> It has a list of ck_constraint_parse objects, which have =
ck_constraint_def
> objects. What is the memory they are allocated on?
>=20
On region.
=
https://github.com/tarantool/tarantool/blob/0dc72812fb78a192945612f0e95402=
6a0ffe4053/src/box/sql/build.c#L614
=
https://github.com/tarantool/tarantool/blob/0dc72812fb78a192945612f0e95402=
6a0ffe4053/src/box/sql/build.c#L1979=