From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id CFA63242F6
	for <tarantool-patches@freelists.org>; Wed, 16 Jan 2019 10:35:19 -0500 (EST)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id n6VPgcMdDsOa for <tarantool-patches@freelists.org>;
	Wed, 16 Jan 2019 10:35:19 -0500 (EST)
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 8C35224210
	for <tarantool-patches@freelists.org>; Wed, 16 Jan 2019 10:35:19 -0500 (EST)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\))
Subject: [tarantool-patches] Re: [PATCH v3 4/6] sql: fix "PRAGMA case_sensitive_like" result
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <2589721198edcf039cfdc98a18d9e0670e6e67af.1545844480.git.imeevma@gmail.com>
Date: Wed, 16 Jan 2019 18:35:17 +0300
Content-Transfer-Encoding: 7bit
Message-Id: <B0D563CE-A62A-4273-ABE7-60AF590F4F7D@tarantool.org>
References: <cover.1545844480.git.imeevma@gmail.com>
 <2589721198edcf039cfdc98a18d9e0670e6e67af.1545844480.git.imeevma@gmail.com>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>


> diff --git a/test/sql/misc.test.lua b/test/sql/misc.test.lua
> index 994e64f..cc31a5d 100644
> --- a/test/sql/misc.test.lua
> +++ b/test/sql/misc.test.lua
> @@ -11,3 +11,16 @@ box.sql.execute(';')
> box.sql.execute('')
> box.sql.execute('     ;')
> box.sql.execute('\n\n\n\t\t\t   ')
> +
> +--
> +-- gh-3832: Some statements do not return column type
> +
> +-- Check that "PRAGMA case_sensitive_like" returns 0 or 1 if
> +-- called without parameter.
> +result = box.sql.execute('PRAGMA case_sensitive_like')
> +-- Should be nothing.
> +box.sql.execute('PRAGMA case_sensitive_like = 1')
> +-- Should be 1.
> +box.sql.execute('PRAGMA case_sensitive_like')
> +-- Should be nothing.

Again: useless comments.
The rest is OK.