From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 7F44722CCD for ; Wed, 27 Jun 2018 13:41:55 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bzCdgcajz1Gj for ; Wed, 27 Jun 2018 13:41:55 -0400 (EDT) Received: from smtp15.mail.ru (smtp15.mail.ru [94.100.176.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id B1051225E7 for ; Wed, 27 Jun 2018 13:41:54 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: [tarantool-patches] Re: [PATCH v4 6/8] sql: refactor AST trigger object name From: "n.pettik" In-Reply-To: <3563ea71-30c6-3f20-8484-7970786c3de6@tarantool.org> Date: Wed, 27 Jun 2018 20:41:50 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: References: <81986d1f9307191bd3d3e37514dc32fadb7e6970.1530029141.git.kshcherbatov@tarantool.org> <3563ea71-30c6-3f20-8484-7970786c3de6@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Kirill Shcherbatov > -void sql_trigger_finish(Parse *, TriggerStep *, Token *); > +void > +sql_trigger_finish(struct Parse *parse, struct TriggerStep = *step_list, > + struct Token *token); >=20 >> You don=E2=80=99t need to declare all variables beforehand: its = obsolete style >> used in SQLite. > It is important here, as there is goto clause before first usage.=20 > This variable should be initialized with NULL.=20 I mean not all of these variables are initialised. For example, you can = move /* Name of trigger. */ char *trigger_name; closer to its usage. Surely, it is not vital, but anyway.=20