From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A2B186EC58; Sun, 1 Aug 2021 20:01:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A2B186EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627837304; bh=v5yoKZbAoZRW09fkuv7qyRnKkTHNcXtjh3HKgVXaDbQ=; h=In-Reply-To:Date:References:To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=HH7OGFUuWdKBpelU2tEU4HlIKb/+BSnIIsbYjm91lcYS+A4sFz1CR0SW1e2gP4SO7 Phy15ILgFtNv82WTlu++7C+sMDe5M4+XGHG0VbajYz0O2Sjn9kkG8G51ofqb6qBOqH UyHqvLJC6Aj3stfpct2zfC/mt0klzUi/y4uSRG7M= Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9D94B6EC58 for ; Sun, 1 Aug 2021 20:01:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9D94B6EC58 Received: by smtp49.i.mail.ru with esmtpa (envelope-from ) id 1mAEpy-0002ej-2l; Sun, 01 Aug 2021 20:01:18 +0300 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) In-Reply-To: Date: Sun, 1 Aug 2021 20:01:16 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Vladislav Shpilevoy X-Mailer: Apple Mail (2.3654.100.0.2.22) X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C351B198F4576AC7B2770D7874BA03B4AE182A05F538085040EE29544FD6E28BD897F1BAF287621133AA8F572F55A0F1D0DCDA5B9864987461 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C4470ABEE4BC4B50EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E25DEE08FA4D750E8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8F699038417E69407B170059A21B9E0C8117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC1F8789D36234D406A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FBDFBBEFFF4125B51D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B67393CE827C55B5F775ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5B72C7B9BD87A1396ECFD076015362356DD40E2FE8FB307C4D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA751B940EDA0DFB0535410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3480665FBD8F49180C81AB07E9D1C863557DBA65B49784601082A419E0698B5BE69CD382E8D6A17BF11D7E09C32AA3244C19ECA436BF1C655CE7771AEB8B0F0708250262A5EE9971B0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojMCfuYI4PrecD5XBQINhQcg== X-Mailru-Sender: 3B9A0136629DC912F4AABCEFC589C81EE06B0CAA012EB0EF397931940D3589E319B1D5C515718BEFAD07DD1419AC565FA614486B47F28B67C5E079CCF3B0523AED31B7EB2E253A9E112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 2/5] info: use luaL_pushuuidstr() for box.info uuids X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Ostanevich via Tarantool-patches Reply-To: Sergey Ostanevich Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks! LGTM. > On 1 Aug 2021, at 18:03, Vladislav Shpilevoy = wrote: >=20 > Hi! Thanks for the review! >=20 >>> diff --git a/test/app-tap/gh-5632-6050-gc-buf-reuse.test.lua = b/test/app-tap/gh-5632-6050-6259-gc-buf-reuse.test.lua >>> similarity index 79% >>> rename from test/app-tap/gh-5632-6050-gc-buf-reuse.test.lua >>> rename to test/app-tap/gh-5632-6050-6259-gc-buf-reuse.test.lua >>> index bf7590a14..f806ba6b7 100755 >>> --- a/=09 >>> +++ b/test/app-tap/gh-5632-6050-6259-gc-buf-reuse.test.lua >>> @@ -190,11 +190,47 @@ local function test_json(test) >>> test:ok(is_success, 'json in gc') >>> end >>>=20 >>> -local test =3D tap.test('gh-5632-6050-gc-buf-reuse') >>> -test:plan(4) >>> +local function test_info_uuid(test) >>> + test:plan(1) >>> + >>> + local gc_count =3D 100 >>> + local iter_count =3D 1000 >>> + local is_success =3D true >>> + >>> + local function uuid_to_str() >>> + local uu =3D uuid.new() >>> + local str1 =3D box.info.uuid >>> + local str2 =3D box.info.cluster.uuid >>> + local str3 =3D box.info.uuid >>> + local str4 =3D box.info.cluster.uuid >>> + if str1 ~=3D str3 or str2 ~=3D str4 then >>> + is_success =3D false >>> + assert(false) >>=20 >> Why did you keep the assert? I believe there should be just a non-ok = in test? >=20 > Dropped on the branch.