From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E782B26105 for ; Tue, 29 Jan 2019 07:31:59 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XwvCH0WRy9br for ; Tue, 29 Jan 2019 07:31:59 -0500 (EST) Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [94.100.177.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 4E51B2609B for ; Tue, 29 Jan 2019 07:31:59 -0500 (EST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: [tarantool-patches] Re: [PATCH v2] sql: prohibit type_def keywords in the VALUES statement From: "n.pettik" In-Reply-To: <20190129105518.22723-1-szudin@tarantool.org> Date: Tue, 29 Jan 2019 15:31:56 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20190129105518.22723-1-szudin@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: szudin@tarantool.org > The parser didn't distinguish the type definition keywords from = values. Why did you change your commit message? It was good except for that it was not formatted. Lets return it back, format (align text = border to 72 chars) and then patch will be entirely OK. > Closes #3888 > --- > Branch: = https://github.com/tarantool/tarantool/tree/sz/gh-3888-values-blob-assert > Issue: https://github.com/tarantool/tarantool/issues/3888 > =E2=80=94 Don=E2=80=99t put this delimiter again (next time), it should appear = only once.=