From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id C90732FE4C for ; Wed, 14 Nov 2018 16:48:48 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zeTGOBu83gtx for ; Wed, 14 Nov 2018 16:48:48 -0500 (EST) Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 1419B2FC75 for ; Wed, 14 Nov 2018 16:48:47 -0500 (EST) From: "n.pettik" Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_9AA020FB-B8D6-404B-9604-FF805B57360E" Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\)) Subject: [tarantool-patches] Re: [PATCH 2/2] sql: remove GLOB from Tarantool Date: Thu, 15 Nov 2018 00:48:38 +0300 In-Reply-To: <20181114174106.nvdjpixk57cd4aq3@tkn_work_nb> References: <3f8354cb-4a47-c3de-164b-c776c792b991@tarantool.org> <090683CD-6F88-492D-AF48-631220A24E36@tarantool.org> <20181021034805.alwhmkpz3fbopqjz@tkn_work_nb> <20181029121529.2d6ccnh5qayiz7ld@tkn_work_nb> <6F5AC823-3016-4918-A588-6BB6B621B777@tarantool.org> <20181109121828.mjdoouycwvonimms@tkn_work_nb> <34EFA3FE-95C1-49FC-9668-11DDD93EC42D@tarantool.org> <20181113192305.v3uxbrp6ebqrb4gs@tkn_work_nb> <086379A5-15D0-4D16-951E-5F5DBE852068@tarantool.org> <20181114174106.nvdjpixk57cd4aq3@tkn_work_nb> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Alexander Turenko , Nikita Tatunov , Kirill Yukhin --Apple-Mail=_9AA020FB-B8D6-404B-9604-FF805B57360E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 >> Also I don=E2=80=99t like the fact that your patch not only removes >> GLOB function, but also changes some user-visible interface. >> It still would be OK if you wrote about it in commit message >> or in doc request. For instance, as I understand from code, >> percent symbol (=E2=80=98%=E2=80=99) now works as star (=E2=80=98*=E2=80= =99) did before. >>=20 >=20 > '*' from GLOB is subject to remove, '%' from LIKE still doing its = work. > Comments that use names of symbols from GLOB are changed to use LIKE > syntax. My bad. Original comments in source code turned out to be incomplete and misleading a bit.=20 >> Finally, to be honest I didn=E2=80=99t review ALL changed tests. >> I looked through and they seem to be OK. >>=20 >> I=E2=80=99ve pushed also several non-functional fixes - >> see branch np/gh-3251-where-like-hangs. >>=20 >=20 > Don't have objections against your changes. >=20 >> Let's assume this as formal LGTM. OK, then I am going to squash commits with fixes and patch will be ready to push. Kirill, note that updated branch to push is: np/gh-3251-where-like-hangs --Apple-Mail=_9AA020FB-B8D6-404B-9604-FF805B57360E Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

Also = I don=E2=80=99t like the fact that your patch not only removes
GLOB function, but also changes some user-visible = interface.
It still would be OK if you wrote about it in = commit message
or in doc request. For instance, as I = understand from code,
percent symbol (=E2=80=98%=E2=80=99) = now works as star (=E2=80=98*=E2=80=99) did before.


'*' from GLOB is subject to remove, '%' from LIKE still doing = its work.
Comments that = use names of symbols from GLOB are changed to use LIKE
syntax.

My bad. = Original comments in source code turned out to be
incomplete = and misleading a bit. 

Finally, to be honest I didn=E2=80=99t = review ALL changed tests.
I looked through and they seem = to be OK.

I=E2=80=99ve pushed also several = non-functional fixes -
see branch = np/gh-3251-where-like-hangs.

Don't have objections against = your changes.

Let's = assume this as formal LGTM.

OK, then I am going to squash commits with = fixes
and patch will be ready to push.

Kirill, note that updated branch to push = is:
np/gh-3251-where-like-hangs

= --Apple-Mail=_9AA020FB-B8D6-404B-9604-FF805B57360E--