>> Also I don’t like the fact that your patch not only removes >> GLOB function, but also changes some user-visible interface. >> It still would be OK if you wrote about it in commit message >> or in doc request. For instance, as I understand from code, >> percent symbol (‘%’) now works as star (‘*’) did before. >> > > '*' from GLOB is subject to remove, '%' from LIKE still doing its work. > Comments that use names of symbols from GLOB are changed to use LIKE > syntax. My bad. Original comments in source code turned out to be incomplete and misleading a bit. >> Finally, to be honest I didn’t review ALL changed tests. >> I looked through and they seem to be OK. >> >> I’ve pushed also several non-functional fixes - >> see branch np/gh-3251-where-like-hangs. >> > > Don't have objections against your changes. > >> Let's assume this as formal LGTM. OK, then I am going to squash commits with fixes and patch will be ready to push. Kirill, note that updated branch to push is: np/gh-3251-where-like-hangs