From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <k.sosnin@tarantool.org>
Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 7B6FF46970E
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 16 Jan 2020 11:10:34 +0300 (MSK)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\))
From: Chris Sosnin <k.sosnin@tarantool.org>
In-Reply-To: <20200115172944.GC82780@tarantool.org>
Date: Thu, 16 Jan 2020 11:10:32 +0300
Content-Transfer-Encoding: 7bit
Message-Id: <AB55A62C-AA31-4EFF-B572-E813077B733A@tarantool.org>
References: <20200110074051.67668-1-k.sosnin@tarantool.org>
 <20200115172944.GC82780@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] sql: fix assertion fail when
 selecting from _vfunc
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi! Thank you for the review!

> LGTM as well. Don't you forget edit snapshot in binary mode (asking
> just in case)?


I have done it using vim -b.