From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id AAF1442EF5C for ; Thu, 2 Jul 2020 13:25:28 +0300 (MSK) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) From: Chris Sosnin In-Reply-To: <9f523f8f-cb74-bb61-e044-b8d82692d28a@tarantool.org> Date: Thu, 2 Jul 2020 13:25:26 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: References: <070b81c4-c752-01ef-c004-4d768260809d@tarantool.org> <20200626115843.68530-1-k.sosnin@tarantool.org> <9f523f8f-cb74-bb61-e044-b8d82692d28a@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] decimal: introduce decimal_is_int List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Thank you for your answers, this will be helpful. > On 28 Jun 2020, at 19:53, Vladislav Shpilevoy = wrote: >=20 > On 26/06/2020 13:58, Chris Sosnin wrote: >> Thank you for the review! >> For some reason I thought we don't need a wrapper for a function >> that doesn't require context and the status check. >=20 > You need. Because decNumber code style is too different, even in > declarations. Also we use decimal_t type, not decNumber. Even though > they are the same for now. But this may change. >=20 >> So does it mean >> I should also wrap isZero and similar calls in my SQL patchset? >=20 > Yes. All decimal functions should be decimal_*(). Not decNumber*(). At > least this is how I understand it. Sergey may have different thoughts. >=20 > The patchset LGTM. decNumber patchset has 2 LGTMs, and wrappers for the core have one, can = we push it? I could rebase on it and continue finalizing decimals.=