From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 859E16901E; Wed, 14 Apr 2021 20:52:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 859E16901E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618422734; bh=7Yi173s3bbagAnaPhK96YbIMuC+eXJZGbHF5sNg8oK8=; h=In-Reply-To:Date:Cc:References:To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=sIfnztphQxoipbvy3D3OdbHrBv6Mpion+LqKpyzdDSOyKWHeP0Jtk3v8I/dEbXNNR vGLtQHpikclancniocRCZDgDfs2Ntoqo6kFcNzV9lv9+lRW08kFXR7FFMaeXdIaEJP JNqLelzKDGNdg7yn6c1fSd2pSs/NlRZFeTQl2l6Y= Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2FFCB6901B for ; Wed, 14 Apr 2021 20:52:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2FFCB6901B Received: by smtp47.i.mail.ru with esmtpa (envelope-from ) id 1lWjgS-00043N-BO; Wed, 14 Apr 2021 20:52:12 +0300 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) In-Reply-To: <8d5f9e4d-ccf7-61bb-d80f-b285342f1b04@tarantool.org> Date: Wed, 14 Apr 2021 20:52:10 +0300 Cc: tarantool-patches@dev.tarantool.org, Alexander Turenko Content-Transfer-Encoding: quoted-printable Message-Id: References: <20210319141308.98726-1-roman.habibov@tarantool.org> <8d5f9e4d-ccf7-61bb-d80f-b285342f1b04@tarantool.org> To: Leonid Vasiliev X-Mailer: Apple Mail (2.3608.120.23.2.1) X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E7480EBD5CA77A668ECB87DA2124B0A8E6609182A05F538085040BE4BE434AE5B478AEB44CA8705BFB06008A86ECEADD18E03772ECE78B9CF978F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE712EB008F780777E9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CF19945FAF91394A8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B26CEE05F05ED7E04DC0FE05D2FA63020F4AEA611A897B002DD2E47CDBA5A96583C09775C1D3CA48CFE478A468B35FE767117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE74A95F4E53E8DCE969FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE7CE94B696AC1871D4D32BA5DBAC0009BE395957E7521B51C20BC6067A898B09E4090A508E0FED6299176DF2183F8FC7C0D51C44EAE4F6F377CD04E86FAF290E2DE7108DC36ECF87B51DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C321259270BBF67A2035872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24209795067102C07E8F7B195E1C978311E80CA685BCED6FBDABE82F96B12BFBC X-C1DE0DAB: 0D63561A33F958A5381C5283A9FEB4B33D9458A328ABD5B60B7B53E066BE4600D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349C39CCCDAABCB54B2F8C999BDC80D2D1F92ABB4BB39BDC76EF1C735ED5E74836684F76BB3788917A1D7E09C32AA3244CF72C3C825526528F9554E964DA52049364EE5813BBCA3A9DFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojrcJA+pXcDum+KEDaY8cW/w== X-Mailru-Sender: 583F1D7ACE8F49BDEA3C271978C0A83999A6F6857505D6FAEB27FEA2FCAAD99E2BDFFD4F4799C819348FE6A8006F2EC50E3B0B3837CF9D06B66783F999AF26D6B245F98531AE10CE112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 0/3] Export curl symbols, enable smtp and install headers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Roman Khabibov via Tarantool-patches Reply-To: Roman Khabibov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! > On Apr 13, 2021, at 16:14, Leonid Vasiliev = wrote: >=20 > Hi! Thank you for the patchset. > Generally LGTM. > See several commits below: > 1) Add changelogs. > 2) Have you checked the patch on some deb and rpm based distributions? >=20 >=20 > On 3/19/21 5:13 PM, Roman Khabibov via Tarantool-patches wrote: >> The patchset is for 1.10 only. >> Issue: https://github.com/tarantool/smtp/issues/24 >> Branch: = https://github.com/tarantool/tarantool/tree/romanhabibov/curl-smtp_1_10 >> Roman Khabibov (3): >> build: export libCURL symbols >> build: enable smtp in libCURL >> build: install libCURL headers >> CMakeLists.txt | 17 ++++ >> cmake/BuildLibCURL.cmake | 2 +- >> extra/curl_symbols | 81 ++++++++++++++++ >> extra/mkexports | 14 ++- >> rpm/tarantool.spec | 9 ++ >> src/CMakeLists.txt | 5 +- >> test/box-tap/curl-build.test.lua | 160 = +++++++++++++++++++++++++++++++ >> 7 files changed, 282 insertions(+), 6 deletions(-) >> create mode 100755 extra/curl_symbols >> create mode 100755 test/box-tap/curl-build.test.lua All is done. On two branches.=