From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id C83F126EBF
	for <tarantool-patches@freelists.org>; Mon, 11 Mar 2019 14:44:58 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id hXs1xe2G8wUl for <tarantool-patches@freelists.org>;
	Mon, 11 Mar 2019 14:44:58 -0400 (EDT)
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 82EB526E8A
	for <tarantool-patches@freelists.org>; Mon, 11 Mar 2019 14:44:58 -0400 (EDT)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: [tarantool-patches] Re: [PATCH v2 1/9] box: fix upgrade script for
 _fk_constraint space
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <87984ddaed8565938269bab296e8a162c18e3bb0.1548838034.git.kshcherbatov@tarantool.org>
Date: Mon, 11 Mar 2019 21:44:56 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <A51229D0-0FB5-4DE1-810B-A9B0EF71F6F0@tarantool.org>
References: <cover.1548838034.git.kshcherbatov@tarantool.org>
 <87984ddaed8565938269bab296e8a162c18e3bb0.1548838034.git.kshcherbatov@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>

LGTM as obvious. I guess it is barely related to the
patch-set and can be pushed separately from other
patches.

> The set_system_triggers and erase routines in upgrade.lua did not
> proceed actions for _fk_constraint space.
> ---
> src/box/lua/upgrade.lua | 2 ++
> 1 file changed, 2 insertions(+)
>=20
> diff --git a/src/box/lua/upgrade.lua b/src/box/lua/upgrade.lua
> index 3d9acc976..81f578e58 100644
> --- a/src/box/lua/upgrade.lua
> +++ b/src/box/lua/upgrade.lua
> @@ -71,6 +71,7 @@ local function set_system_triggers(val)
>     box.space._priv:run_triggers(val)
>     box.space._trigger:run_triggers(val)
>     box.space._collation:run_triggers(val)
> +    box.space._fk_constraint:run_triggers(val)
> end
>=20
> =
--------------------------------------------------------------------------=
------
> @@ -88,6 +89,7 @@ local function erase()
>     truncate(box.space._truncate)
>     truncate(box.space._collation)
>     truncate(box.space._trigger)
> +    truncate(box.space._fk_constraint)
>     --truncate(box.space._schema)
>     box.space._schema:delete('version')
>     box.space._schema:delete('max_id')
> --=20
> 2.19.2
>=20
>=20