From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 47B576EC5B; Thu, 13 May 2021 12:50:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 47B576EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1620899415; bh=N0drCLe0Rs3+OVbwCA4CUBImHKlvWUZdWscDnNEW6uI=; h=Date:In-Reply-To:To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=DmEjomNynY7Ga3GhzD+14M+OHr+MyTHiPOD01RZsBbUycxZicEj375Ht0T8Cyk5uv HCEa4YRJtbTy4pud/sjD6YC/yRDexC84C997rB7lehyvqdB0OCo2ApbCJIT+m17DdD +h6XkJS297Jmx/MGYH+eEVKpI0qirZ5rfmlLKoHo= Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id F19A36EC5B for ; Thu, 13 May 2021 12:50:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F19A36EC5B Received: by smtp52.i.mail.ru with esmtpa (envelope-from ) id 1lh7yv-0006XD-4o; Thu, 13 May 2021 12:50:13 +0300 Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_B08CA380-0CC8-42EE-8459-57065D24D756" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Date: Thu, 13 May 2021 12:50:07 +0300 In-Reply-To: <20210512215956.GF3944@tarantool.org> To: Igor Munkin References: <6753245c0309ed77250a6ac41fb7bfd3f82676c2.1620678384.git.imun@tarantool.org> <20210511113115.GD3944@tarantool.org> <2922F816-67DD-45D0-8F97-6CA2EB36F66E@tarantool.org> <20210512215956.GF3944@tarantool.org> X-Mailer: Apple Mail (2.3654.60.0.2.21) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD95978C26455E69BE0ABDB394FB841241C41AA4B146174B5D1182A05F53808504046EC8FB95C3CFB0A5D78195034CA6EE5B4A688A90DEBF1C7576582B0A85F1355 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE758E3775C3D7FDEE4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637782358EF9635990EEA1F7E6F0F101C67CDEEF6D7F21E0D1D9295C2E9FA3191EE1B59CA4C82EFA658393BD36389ECFAAF9EE22837C8173E22F6B57BC7E64490618DEB871D839B73339E8FC8737B5C22495FF0BFC5AEE34BE6CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C091DAD9F922AA71188941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3CE9959E2676FD87735872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5265D83B626230997F6429894D96244562F41AD0335D75EFDD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75F04B387B5D7535DE410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34ADE558D2B396DA7C14DC4F6150984512932A5ED2CEA17CC41DB4836AC7083F97187BA914435C26161D7E09C32AA3244CFCF60B71719702EEF025FC7591511433C3B3ADDA61883BB5FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojo6y/qPNd2uwACr5kMixAWw== X-Mailru-Sender: 3B9A0136629DC912F4AABCEFC589C81E40FE54614EF40082939A98DA7A7C13D2D6E7897F54F6C62FAD07DD1419AC565FA614486B47F28B67C5E079CCF3B0523AED31B7EB2E253A9E112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/3] FFI/ARM64/OSX: Fix vararg call handling. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Ostanevich via Tarantool-patches Reply-To: Sergey Ostanevich Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" --Apple-Mail=_B08CA380-0CC8-42EE-8459-57065D24D756 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Well, this doesn't help me with > Since all LJ_TARGET_IOS usage is done with LJ_TARGET_ARM64 define = being > set, we can simply replace all occurrences with LJ_TARGET_OSX. alongside with > src/lj_prng.c:112:#if LJ_TARGET_OSX && !LJ_TARGET_IOS because if we apply first then the second will evaluate into src/lj_prng.c:112:#if LJ_TARGET_OSX && !LJ_TARGET_OSX which is always false? Also there are still operable 32bit apps, including games, so iOS still = supports 32bits - can this change cause problems? I believe Mike = doesn=E2=80=99t care too much, so it can easily slip through. Sergos > On 13 May 2021, at 00:59, Igor Munkin wrote: >=20 > Sergos, >=20 > On 12.05.21, Sergey Ostanevich wrote: >> Hi! >>=20 >> I can=E2=80=99t get this then >>=20 >> src/lj_prng.c:112:#if LJ_TARGET_OSX && !LJ_TARGET_IOS >=20 > There is a verbose comment nearby[1] and the corresponding issue[2]. >=20 >>=20 >> How=E2=80=99s that survived in 2.1 branch? >>=20 >> regards, >> Sergos >>=20 >>=20 >>> On 11 May 2021, at 14:31, Igor Munkin wrote: >>>=20 >>> Sergey, >>>=20 >>> Thanks for your review! >>>=20 >>> On 11.05.21, Sergey Kaplun wrote: >>>> Hi, Igor! >>>>=20 >>>> Thanks for the patch! >>>> LGTM! >>>=20 >>> Added your tag: >>> | Reviewed-by: Sergey Kaplun >>>=20 >>> Also mentioned the issue[1]: >>> | Resolves tarantool/tarantool#6066 >>>=20 >>>>=20 >>>> --=20 >>>> Best regards, >>>> Sergey Kaplun >>>=20 >>> [1]: https://github.com/tarantool/tarantool/issues/6066 >>>=20 >>> --=20 >>> Best regards, >>> IM >>=20 >=20 > [1]: = https://github.com/LuaJIT/LuaJIT/blob/v2.1/src/lj_prng.c#L113-L119 > [2]: https://github.com/LuaJIT/LuaJIT/issues/668 >=20 > --=20 > Best regards, > IM --Apple-Mail=_B08CA380-0CC8-42EE-8459-57065D24D756 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Well,= this doesn't help me with

> Since all LJ_TARGET_IOS usage is done with LJ_TARGET_ARM64 = define being
> = set, we can simply replace all occurrences with LJ_TARGET_OSX.

alongside with

> src/lj_prng.c:112:#if LJ_TARGET_OSX = && !LJ_TARGET_IOS

because if = we apply first then the second will evaluate into

src/lj_prng.c:112:#if LJ_TARGET_OSX && = !LJ_TARGET_OSX

which is always = false?

Also there are still operable 32bit apps, including games, so = iOS still supports 32bits - can this change cause problems? = I believe Mike doesn=E2=80=99t care too much, so it can easily = slip through.
Sergos



On 13 = May 2021, at 00:59, Igor Munkin <imun@tarantool.org> wrote:

Sergos,

On 12.05.21, Sergey = Ostanevich wrote:
Hi!

I can=E2=80=99t get this = then

 src/lj_prng.c:112:#if = LJ_TARGET_OSX && !LJ_TARGET_IOS

There is a verbose comment nearby[1] and the corresponding = issue[2].


How=E2=80=99s that survived in 2.1 branch?

regards,
Sergos


On 11 May = 2021, at 14:31, Igor Munkin <imun@tarantool.org> wrote:

Sergey,

Thanks for your = review!

On 11.05.21, Sergey Kaplun = wrote:
Hi, Igor!

Thanks for the patch!
LGTM!

Added your tag:
| = Reviewed-by: Sergey Kaplun <skaplun@tarantool.org>

Also= mentioned the issue[1]:
| Resolves = tarantool/tarantool#6066


--
Best = regards,
Sergey Kaplun

[1]: https://github.com/tarantool/tarantool/issues/6066

--
Best regards,
IM


[1]: https://github.com/LuaJIT/LuaJIT/blob/v2.1/src/lj_prng.c#L113-L= 119
[2]: https://github.com/LuaJIT/LuaJIT/issues/668

--
Best regards,
IM

= --Apple-Mail=_B08CA380-0CC8-42EE-8459-57065D24D756--