From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 5BF314696C3
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 11 Apr 2020 16:12:20 +0300 (MSK)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\))
From: Serge Petrenko <sergepetrenko@tarantool.org>
In-Reply-To: <11473075-0c39-cda2-68e4-0dd1f6469f3d@tarantool.org>
Date: Sat, 11 Apr 2020 16:12:19 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <A3122420-A9C5-4C90-8167-460C850BEF65@tarantool.org>
References: <cover.1586476073.git.sergepetrenko@tarantool.org>
 <616426a33b353b302f155b01e22cbf61ba5f768c.1586476073.git.sergepetrenko@tarantool.org>
 <11473075-0c39-cda2-68e4-0dd1f6469f3d@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 1/4] refactoring: extract
 mpstream into a separate library
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org



> 10 =D0=B0=D0=BF=D1=80. 2020 =D0=B3., =D0=B2 19:56, Vladislav Shpilevoy =
<v.shpilevoy@tarantool.org> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=
=B0):
>=20
> Thanks for the patch!

Thanks for the review!

>=20
>> diff --git a/src/lib/core/mpstream.c b/src/lib/mpstream/mpstream.c
>> similarity index 99%
>> rename from src/lib/core/mpstream.c
>> rename to src/lib/mpstream/mpstream.c
>> index 2be1797d0..a737212c1 100644
>> --- a/src/lib/core/mpstream.c
>> +++ b/src/lib/mpstream/mpstream.c
>> @@ -33,7 +33,7 @@
>> #include <assert.h>
>> #include <stdint.h>
>> #include "msgpuck.h"
>> -#include "mp_decimal.h"
>> +#include "core/mp_decimal.h"
>=20
> You can keep it as is, anyway core/ is added to -I, so
> all files there are visible without core/ prefix. In all
> next patches too.

Indeed, thanks!

diff --git a/src/lib/mpstream/mpstream.c b/src/lib/mpstream/mpstream.c
index a737212c1..2be1797d0 100644
--- a/src/lib/mpstream/mpstream.c
+++ b/src/lib/mpstream/mpstream.c
@@ -33,7 +33,7 @@
 #include <assert.h>
 #include <stdint.h>
 #include "msgpuck.h"
-#include "core/mp_decimal.h"
+#include "mp_decimal.h"
=20
 void
 mpstream_reserve_slow(struct mpstream *stream, size_t size)

--
Serge Petrenko
sergepetrenko@tarantool.org