Re: [Tarantool-patches] [PATCH v2 luajit 00/30] Adapt PUC-Rio Lua 5.1 test suite

[Sergey Ostanevich via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi!

Thanks for the patch set!

Overall I’m not happy with amount of output from the testing.
Can we put some redirection about it? 

Sergos

log example:
———————————

    —— total memory: 23K ----

testing debug library and debug information
+
...................................................................................................................+
OK
    ---- total memory: 2K ----

testing functions and calls
+
+
+
+
......................................................................................................................................................................................................................................................................OK
    ---- total memory: 1K ----

testing strings and string library
+
+
+
+
+
OK
    ---- total memory: 2K ----


> On 26 Mar 2021, at 10:42, Sergey Kaplun <skaplun@tarantool.org> wrote:
> 
> Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-5845-adapt-puc-rio-test-suite-v2
> Test branch: https://github.com/tarantool/tarantool/tree/skaplun/gh-5845-adapt-puc-rio-test-suite-v2
> 
> Side note: I reword commit about variable names in error messages a
> little, so the commit is different but the conten is the same.
> 
> Issues:
> * https://github.com/tarantool/tarantool/issues/5845
> * https://github.com/tarantool/tarantool/issues/4473
> 
> Suite is taken intact exept trailing whitespaces.
> Command to check:
> | $ diff -ruZ --color ../test/PUC-Lua-5.1-tests/ ~/Downloads/lua5.1-tests/
> | Only in ../test/PUC-Lua-5.1-tests/: CMakeLists.txt
> | Only in ../test/PUC-Lua-5.1-tests/libs: CMakeLists.txt
> | Only in ~/Downloads/lua5.1-tests/libs: makefile
> | Only in ~/Downloads/lua5.1-tests/libs: P1
> 
> Changes in the v2:
> * split commits to atomic changes
> * more verbose comments for some tests
> * some test fixed instead commenting
> 
> Sergey Kaplun (30):
>  test: add PUC-Rio Lua 5.1 test suite
>  test: add compiling for C libs from PUC-Rio-Lua5.1
>  test: adapt Lua 5.1 suite for out-of-source build
>  test: remove quotes in progname from <main.lua>
>  test: adapt arg availability test from Lua suite
>  test: disable PUC Lua tests confused by -v output
>  test: disable Lua tests for bytecode with header
>  test: disable JIT for GC step counting tests
>  test: disable Lua suite tests for line hook
>  test: adapt test for debug.setlocal in Lua suite
>  test: adapt getlocal PUC test for vararg func
>  test: adapt PUC Lua test with count hooks
>  test: disable PUC Lua test for tail call info
>  test: adapt activeline check in the PUC Lua test
>  test: disable PUC-Lua test for per-coroutine hooks
>  test: adapt PUC Lua test for %q in fmt for LuaJIT
>  test: disable locale-depended tests for Lua suite
>  test: replace math.mod to math.fmod for Lua tests
>  test: remove assert for string.gfind check
>  test: adapt PUC Lua test for args in vararg func
>  test: disable test for getfenv in closure tailcall
>  test: disable PUC Lua test for var names in error
>  test: disable PUC Lua test for fast function name
>  test: disable PUC Lua test for non-asci identifier
>  test: disable PUC Lua error test for syntax level
>  test: disable tests with multiple -l options
>  test: disable PUC Lua test for checking arg layout
>  test: disable PUC Lua test checking -h option
>  test: disable PUC Lua hanging GC test
>  test: disable too depth recursive PUC Lua test
> 
> .luacheckrc                                |    5 +-
> test/CMakeLists.txt                        |    2 +
> test/PUC-Lua-5.1-tests/CMakeLists.txt      |   46 +
> test/PUC-Lua-5.1-tests/README              |   41 +
> test/PUC-Lua-5.1-tests/all.lua             |  146 +++
> test/PUC-Lua-5.1-tests/api.lua             |  711 ++++++++++++
> test/PUC-Lua-5.1-tests/attrib.lua          |  339 ++++++
> test/PUC-Lua-5.1-tests/big.lua             |  381 +++++++
> test/PUC-Lua-5.1-tests/calls.lua           |  294 +++++
> test/PUC-Lua-5.1-tests/checktable.lua      |   77 ++
> test/PUC-Lua-5.1-tests/closure.lua         |  430 ++++++++
> test/PUC-Lua-5.1-tests/code.lua            |  143 +++
> test/PUC-Lua-5.1-tests/constructs.lua      |  242 +++++
> test/PUC-Lua-5.1-tests/db.lua              |  576 ++++++++++
> test/PUC-Lua-5.1-tests/errors.lua          |  269 +++++
> test/PUC-Lua-5.1-tests/etc/ltests.c        | 1147 ++++++++++++++++++++
> test/PUC-Lua-5.1-tests/etc/ltests.h        |   92 ++
> test/PUC-Lua-5.1-tests/events.lua          |  360 ++++++
> test/PUC-Lua-5.1-tests/files.lua           |  324 ++++++
> test/PUC-Lua-5.1-tests/gc.lua              |  325 ++++++
> test/PUC-Lua-5.1-tests/libs/CMakeLists.txt |   64 ++
> test/PUC-Lua-5.1-tests/libs/lib1.c         |   40 +
> test/PUC-Lua-5.1-tests/libs/lib11.c        |   18 +
> test/PUC-Lua-5.1-tests/libs/lib2.c         |   28 +
> test/PUC-Lua-5.1-tests/libs/lib21.c        |   18 +
> test/PUC-Lua-5.1-tests/literals.lua        |  181 +++
> test/PUC-Lua-5.1-tests/locals.lua          |  127 +++
> test/PUC-Lua-5.1-tests/main.lua            |  212 ++++
> test/PUC-Lua-5.1-tests/math.lua            |  209 ++++
> test/PUC-Lua-5.1-tests/nextvar.lua         |  397 +++++++
> test/PUC-Lua-5.1-tests/pm.lua              |  276 +++++
> test/PUC-Lua-5.1-tests/sort.lua            |   74 ++
> test/PUC-Lua-5.1-tests/strings.lua         |  191 ++++
> test/PUC-Lua-5.1-tests/vararg.lua          |  134 +++
> test/PUC-Lua-5.1-tests/verybig.lua         |  102 ++
> 35 files changed, 8019 insertions(+), 2 deletions(-)
> create mode 100644 test/PUC-Lua-5.1-tests/CMakeLists.txt
> create mode 100644 test/PUC-Lua-5.1-tests/README
> create mode 100755 test/PUC-Lua-5.1-tests/all.lua
> create mode 100644 test/PUC-Lua-5.1-tests/api.lua
> create mode 100644 test/PUC-Lua-5.1-tests/attrib.lua
> create mode 100644 test/PUC-Lua-5.1-tests/big.lua
> create mode 100644 test/PUC-Lua-5.1-tests/calls.lua
> create mode 100644 test/PUC-Lua-5.1-tests/checktable.lua
> create mode 100644 test/PUC-Lua-5.1-tests/closure.lua
> create mode 100644 test/PUC-Lua-5.1-tests/code.lua
> create mode 100644 test/PUC-Lua-5.1-tests/constructs.lua
> create mode 100644 test/PUC-Lua-5.1-tests/db.lua
> create mode 100644 test/PUC-Lua-5.1-tests/errors.lua
> create mode 100644 test/PUC-Lua-5.1-tests/etc/ltests.c
> create mode 100644 test/PUC-Lua-5.1-tests/etc/ltests.h
> create mode 100644 test/PUC-Lua-5.1-tests/events.lua
> create mode 100644 test/PUC-Lua-5.1-tests/files.lua
> create mode 100644 test/PUC-Lua-5.1-tests/gc.lua
> create mode 100644 test/PUC-Lua-5.1-tests/libs/CMakeLists.txt
> create mode 100644 test/PUC-Lua-5.1-tests/libs/lib1.c
> create mode 100644 test/PUC-Lua-5.1-tests/libs/lib11.c
> create mode 100644 test/PUC-Lua-5.1-tests/libs/lib2.c
> create mode 100644 test/PUC-Lua-5.1-tests/libs/lib21.c
> create mode 100644 test/PUC-Lua-5.1-tests/literals.lua
> create mode 100644 test/PUC-Lua-5.1-tests/locals.lua
> create mode 100644 test/PUC-Lua-5.1-tests/main.lua
> create mode 100644 test/PUC-Lua-5.1-tests/math.lua
> create mode 100644 test/PUC-Lua-5.1-tests/nextvar.lua
> create mode 100644 test/PUC-Lua-5.1-tests/pm.lua
> create mode 100644 test/PUC-Lua-5.1-tests/sort.lua
> create mode 100644 test/PUC-Lua-5.1-tests/strings.lua
> create mode 100644 test/PUC-Lua-5.1-tests/vararg.lua
> create mode 100644 test/PUC-Lua-5.1-tests/verybig.lua
> 
> -- 
> 2.31.0
>