From: sergos via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit 1/3] sysprof: fix interval parsing in dual-number mode Date: Thu, 26 Jan 2023 18:55:51 +0300 [thread overview] Message-ID: <A17AC1C4-1FF7-4B31-9F3F-1EE004531045@tarantool.org> (raw) In-Reply-To: <1588326195edd86f5276ad42143043fbde46abeb.1674068996.git.skaplun@tarantool.org> Hi! Just a nit in message, LGTM. Sergos > On 18 Jan 2023, at 23:16, Sergey Kaplun <skaplun@tarantool.org> wrote: > > When the profiling interval is parsed, `tvisnum()` is used to check that a > the given value is a number. But in case of dual-number mode this check > returns false as far as the given value is an integer, so `tvisnumber()` > should be used to cover both cases. > --- > src/lib_misc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/lib_misc.c b/src/lib_misc.c > index 06fb9f9f..c18d297e 100644 > --- a/src/lib_misc.c > +++ b/src/lib_misc.c > @@ -209,7 +209,7 @@ static int parse_sysprof_opts(lua_State *L, struct luam_Sysprof_Options *opt, in > { > cTValue *interval = lj_tab_getstr(options, lj_str_newlit(L, "interval")); > opt->interval = SYSPROF_DEFAULT_INTERVAL; > - if (interval && tvisnum(interval)) { > + if (interval && tvisnumber(interval)) { > int32_t signed_interval = numberVint(interval); > if (signed_interval < 1) > return PROFILE_ERRUSE; > -- > 2.34.1 >
next prev parent reply other threads:[~2023-01-26 15:56 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-18 20:19 [Tarantool-patches] [PATCH luajit 0/3] Dualnumber mode fixes Sergey Kaplun via Tarantool-patches 2023-01-18 20:16 ` [Tarantool-patches] [PATCH luajit 1/3] sysprof: fix interval parsing in dual-number mode Sergey Kaplun via Tarantool-patches 2023-01-24 14:16 ` Maxim Kokryashkin via Tarantool-patches 2023-01-26 15:55 ` sergos via Tarantool-patches [this message] 2023-01-30 9:39 ` Sergey Kaplun via Tarantool-patches 2023-01-18 20:16 ` [Tarantool-patches] [PATCH luajit 2/3] ci: introduce workflow for exotic builds Sergey Kaplun via Tarantool-patches 2023-01-24 14:20 ` Maxim Kokryashkin via Tarantool-patches 2023-01-26 21:12 ` sergos via Tarantool-patches 2023-01-30 9:51 ` Sergey Kaplun via Tarantool-patches 2023-02-01 8:27 ` Igor Munkin via Tarantool-patches 2023-02-01 8:52 ` Sergey Kaplun via Tarantool-patches 2023-02-02 8:54 ` sergos via Tarantool-patches 2023-01-18 20:16 ` [Tarantool-patches] [PATCH luajit 3/3] x86/x64: Fix loop realignment Sergey Kaplun via Tarantool-patches 2023-01-19 10:17 ` Sergey Kaplun via Tarantool-patches 2023-01-24 15:13 ` Maxim Kokryashkin via Tarantool-patches 2023-01-26 7:06 ` Sergey Kaplun via Tarantool-patches 2023-01-26 14:45 ` Maxim Kokryashkin via Tarantool-patches 2023-01-26 21:22 ` sergos via Tarantool-patches 2023-02-20 9:56 ` [Tarantool-patches] [PATCH luajit 0/3] Dualnumber mode fixes Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=A17AC1C4-1FF7-4B31-9F3F-1EE004531045@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=sergos@tarantool.org \ --cc=skaplun@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit 1/3] sysprof: fix interval parsing in dual-number mode' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox