From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Kirill Shcherbatov Subject: [PATCH v5 03/12] box: introduce tuple_field_go_to_path Date: Mon, 29 Oct 2018 09:56:35 +0300 Message-Id: <9fe671bec3e9eab2f27bf547a058d0c291183fb4.1540795996.git.kshcherbatov@tarantool.org> In-Reply-To: References: In-Reply-To: References: To: tarantool-patches@freelists.org Cc: vdavydov.dev@gmail.com, Kirill Shcherbatov List-ID: The new tuple_field_go_to_path routine is used in function tuple_field_raw_by_path to retrieve data by JSON path from field. We need this routine exported in future to access data by JSON path specified in key_part. Need for #1012 --- src/box/tuple_format.c | 59 +++++++++++++++++++++++++++++++++++--------------- 1 file changed, 42 insertions(+), 17 deletions(-) diff --git a/src/box/tuple_format.c b/src/box/tuple_format.c index c19ff39..6f76158 100644 --- a/src/box/tuple_format.c +++ b/src/box/tuple_format.c @@ -552,6 +552,41 @@ tuple_field_go_to_key(const char **field, const char *key, int len) return -1; } +/** + * Retrieve msgpack data by JSON path. + * @param data Pointer to msgpack with data. + * @param path The path to process. + * @param path_len The length of the @path. + * @retval 0 On success. + * @retval >0 On path parsing error, invalid character position. + */ +static int +tuple_field_go_to_path(const char **data, const char *path, uint32_t path_len) +{ + int rc; + struct json_path_parser parser; + struct json_path_node node; + json_path_parser_create(&parser, path, path_len); + while ((rc = json_path_next(&parser, &node)) == 0) { + switch (node.type) { + case JSON_PATH_NUM: + rc = tuple_field_go_to_index(data, node.num); + break; + case JSON_PATH_STR: + rc = tuple_field_go_to_key(data, node.str, node.len); + break; + default: + assert(node.type == JSON_PATH_END); + return 0; + } + if (rc != 0) { + *data = NULL; + return 0; + } + } + return rc; +} + int tuple_field_raw_by_path(struct tuple_format *format, const char *tuple, const uint32_t *field_map, const char *path, @@ -615,23 +650,13 @@ tuple_field_raw_by_path(struct tuple_format *format, const char *tuple, *field = NULL; return 0; } - while ((rc = json_path_next(&parser, &node)) == 0) { - switch(node.type) { - case JSON_PATH_NUM: - rc = tuple_field_go_to_index(field, node.num); - break; - case JSON_PATH_STR: - rc = tuple_field_go_to_key(field, node.str, node.len); - break; - default: - assert(node.type == JSON_PATH_END); - return 0; - } - if (rc != 0) { - *field = NULL; - return 0; - } - } + rc = tuple_field_go_to_path(field, path + parser.offset, + path_len - parser.offset); + if (rc == 0) + return 0; + /* Setup absolute error position. */ + rc += parser.offset; + error: assert(rc > 0); diag_set(ClientError, ER_ILLEGAL_PARAMS, -- 2.7.4