From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp62.i.mail.ru (smtp62.i.mail.ru [217.69.128.42])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id B1C9542F4AD
 for <tarantool-patches@dev.tarantool.org>;
 Sun, 28 Jun 2020 19:53:39 +0300 (MSK)
References: <070b81c4-c752-01ef-c004-4d768260809d@tarantool.org>
 <20200626115843.68530-1-k.sosnin@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <9f523f8f-cb74-bb61-e044-b8d82692d28a@tarantool.org>
Date: Sun, 28 Jun 2020 18:53:37 +0200
MIME-Version: 1.0
In-Reply-To: <20200626115843.68530-1-k.sosnin@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH] decimal: introduce decimal_is_int
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Chris Sosnin <k.sosnin@tarantool.org>, tarantool-patches@dev.tarantool.org

On 26/06/2020 13:58, Chris Sosnin wrote:
> Thank you for the review!
> For some reason I thought we don't need a wrapper for a function
> that doesn't require context and the status check.

You need. Because decNumber code style is too different, even in
declarations. Also we use decimal_t type, not decNumber. Even though
they are the same for now. But this may change.

> So does it mean
> I should also wrap isZero and similar calls in my SQL patchset?

Yes. All decimal functions should be decimal_*(). Not decNumber*(). At
least this is how I understand it. Sergey may have different thoughts.

The patchset LGTM.