From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 157F5469710
 for <tarantool-patches@dev.tarantool.org>;
 Fri,  8 May 2020 00:53:48 +0300 (MSK)
References: <20200420131115.42047-1-sergepetrenko@tarantool.org>
 <52ac079d-3439-a190-c418-52212a83683c@tarantool.org>
 <7cc455cc-185f-b4cb-17bb-13e3528c63c0@tarantool.org>
 <586c95c1-8bec-8205-402b-24c07ebf603d@tarantool.org>
 <41add5ba-4e48-0242-49bc-6db123466f4b@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <9ebb6d36-c3d1-0d81-ed83-5861c270a73c@tarantool.org>
Date: Thu, 7 May 2020 23:53:47 +0200
MIME-Version: 1.0
In-Reply-To: <41add5ba-4e48-0242-49bc-6db123466f4b@tarantool.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [Tarantool-patches] [PATCH] replication: remove unnecessary
 errors on replicating from an anonymous instance
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the fixes!

>>> @@ -429,36 +430,10 @@ test_run:cmd('set variable repl_source to "replica_anon1.listen"')
>>>   box.cfg{replication=repl_source}
>>>    | ---
>>>    | ...
>>> -
>>> -test_run:cmd('switch default')
>>> - | ---
>>> - | - true
>>> - | ...
>>> -box.space.test:insert{2}
>>> - | ---
>>> - | - [2]
>>> - | ...
>>> -
>>> -test_run:cmd('switch replica_anon1')
>>> - | ---
>>> - | - true
>>> - | ...
>>> --- Check that the new replica follows an anonymous one.
>>> -test_run:wait_downstream(2, {status='follow'})
>>> +test_run:wait_log('replica', 'ER_UNSUPPORTED: Anonymous replica does not support non.anonymous followers.', nil, 10)
>> 2. Perhaps 'non-anonymous' instead of 'non.anonymous'?
> 
> Dot  matches anything, and I couldn't find a way to escape '-', it must be a special symbol of sorts.
> So let it be 'non.anonymous'.

I again forgot how regular expressions look in Lua. Yeah, sure then, '.' is fine.
Talking of escape symbol - it is %