From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C7B0E6EC55; Tue, 15 Jun 2021 23:57:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C7B0E6EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1623790630; bh=x5Zya6o3ajmQ5aPtM6+2glLno0UqK3W1YPED2dOnfMc=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=vR8bU9B8DH5Lht0beHVFMMnRcao6605RLe25DPa7kkG5VPxP639aD9EfoHNhjkSL/ tREQF+Wy3tYG/gsgn9o3fkNSdd9+XeEb5S7mS5W6c9gBKSMiuTxXCv6UKMMursPNNX vXXVBuGr1n2lfpAznIofsVdxwRmNC37W8FLdkkVI= Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6DE2B6EC55 for ; Tue, 15 Jun 2021 23:57:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6DE2B6EC55 Received: by smtp41.i.mail.ru with esmtpa (envelope-from ) id 1ltG7Q-0003Wb-R4; Tue, 15 Jun 2021 23:57:09 +0300 To: Serge Petrenko , gorcunov@gmail.com Cc: tarantool-patches@dev.tarantool.org References: Message-ID: <9e9aa0e6-36af-bdd5-bf8b-e0e5e07195f7@tarantool.org> Date: Tue, 15 Jun 2021 22:57:07 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D5B0DA836B685C54EECC50CDFE52CD8E09EC742E3E75A787182A05F538085040990FA78E3F78D97B764C6B5D938717C0EFF5DE5593BD9D8A4235DA5453F6EE24 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE74378043A27BE1642EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063748D05F5E01EE6C998638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D852DE85A3D7C5DD0CB3555AF27F044010117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352026055571C92BF10F618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE902A1BE408319B29C766E17BBE5724E9D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3A6C7FFFE744CA7FB03F1AB874ED89028C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637BBEA499411984DA1EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2368A440D3B0F6089093C9A16E5BC824A2A04A2ABAA09D25379311020FFC8D4AD5F94BE2FBACB1A8ED40650BB198409FC X-C1DE0DAB: 0D63561A33F958A5C3B0E54EBC3BF354681D81061CD7D5B4C39EFA403AE0C0F6D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34B3611847B8BC2D0BECE477C15D7CA1E191FDBC3FE00A61EEC70EDAED4C8890F11838B6C4DE51F33F1D7E09C32AA3244C774494CBA67F7E03471FCCE61939CEBE7101BF96129E4011FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj6OL1iHTyIM077wlkm35Azw== X-Mailru-Sender: 504CC1E875BF3E7D9BC0E5172ADA311043D6C67628BF0A9536B82E96E670C5AB05FF9F3A45A34F7C07784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 3/7] txn_limbo: fix promote term filtering X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! On 10.06.2021 15:32, Serge Petrenko via Tarantool-patches wrote: > txn_limbo_process() used to filter out promote requests whose term was > equal to the greatest term seen. This wasn't correct for PROMOTE entries > with term 1. > > Such entries appear after box.ctl.promote() is issued on an instance > with disabled elections. Every PROMOTE entry from such an instance has > term 1, but should still be applied. Fix this in the patch. Didn't we agree that PROMOTE should bump the term always? I see no purpose for the PROMOTE which never bumps the term except for the tests, but for such occasion it would be better to have internal.make_leader() or something which bypasses everything. Although the best option would to bump the term always. I see you did something in the last commit about that, but the part about `limbo->promote_greatest_term > 1` still remains. It looks very illegal to point out some terms as "special".