From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4D44C27484 for ; Thu, 26 Jul 2018 16:40:26 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E5wrS5QRyzmW for ; Thu, 26 Jul 2018 16:40:26 -0400 (EDT) Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 0CD822003C for ; Thu, 26 Jul 2018 16:40:25 -0400 (EDT) Received: from [185.6.245.156] (port=48011 helo=msk-wire-v_shpilevoy-v.shpilevoy.mail.msk) by smtp56.i.mail.ru with esmtpa (envelope-from ) id 1fin3g-0004Kg-HX for tarantool-patches@freelists.org; Thu, 26 Jul 2018 23:40:24 +0300 Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: introduce TRUNCATE TABLE operation References: <70326bb69fbe25215df79e2d5e01043f93ff7c5a.1531902074.git.kshcherbatov@tarantool.org> From: Vladislav Shpilevoy Message-ID: <9defc4ee-a670-c0cc-041c-68f7085ab95b@tarantool.org> Date: Thu, 26 Jul 2018 23:40:23 +0300 MIME-Version: 1.0 In-Reply-To: <70326bb69fbe25215df79e2d5e01043f93ff7c5a.1531902074.git.kshcherbatov@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Hi! Thanks for the patch! I have pushed my review fixes on the branch. Please, squash. On 18/07/2018 11:22, Kirill Shcherbatov wrote: > As sql_table_delete_from already support OP_Clear fast cleanup > for non-complex requests we only need to introduce new words > to parser that call DELETE with NULL conditions. > > Closes #2201. > --- > Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-2201-truncate-table > Issue: https://github.com/tarantool/tarantool/issues/2201 >