From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 95EEA2A382 for ; Mon, 1 Apr 2019 16:03:24 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Xy-RKMeNTRwb for ; Mon, 1 Apr 2019 16:03:24 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 5388A2A380 for ; Mon, 1 Apr 2019 16:03:24 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v2 1/1] sql: parameter binding for box.execute() From: Vladislav Shpilevoy References: <01d0c735518c8de3b48050395d9f83cf4dc77d7e.1554148852.git.v.shpilevoy@tarantool.org> Message-ID: <9db2196a-37b5-c786-764c-7022970a6632@tarantool.org> Date: Mon, 1 Apr 2019 23:03:22 +0300 MIME-Version: 1.0 In-Reply-To: <01d0c735518c8de3b48050395d9f83cf4dc77d7e.1554148852.git.v.shpilevoy@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: kyukhin@tarantool.org, imeevma@tarantool.org, Mergen Imeev LGTM. On 01/04/2019 23:02, Vladislav Shpilevoy wrote: > From: Mergen Imeev > > This patch defines parameters binding for SQL statements executed > through box.execute(). > > Closes #3401 > --- > > Changes in v2: > - All the code is moved to box/lua/execute.h > > V1: https://www.freelists.org/post/tarantool-patches/PATCH-v1-11-sql-parameter-binding-for-boxexecute > Branch: https://github.com/tarantool/tarantool/tree/imeevma/gh-3401-add-binding-to-box_execute > Issue: https://github.com/tarantool/tarantool/issues/3401 > > src/box/lua/execute.c | 179 ++++++++++++++++++++++- > test/sql/bind.result | 296 +++++++++++++++++++++++++++++++++++++++ > test/sql/bind.test.lua | 100 +++++++++++++ > test/sql/engine.cfg | 4 + > test/sql/iproto.result | 225 ----------------------------- > test/sql/iproto.test.lua | 69 --------- > 6 files changed, 577 insertions(+), 296 deletions(-) > create mode 100644 test/sql/bind.result > create mode 100644 test/sql/bind.test.lua >