From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 2E2ED41C5DA
 for <tarantool-patches@dev.tarantool.org>;
 Sun, 21 Jun 2020 18:35:52 +0300 (MSK)
References: <cover.1592597647.git.imun@tarantool.org>
 <7b8e95f3d6da39f0c3c6ca742abccddda817ac5e.1592597647.git.imun@tarantool.org>
 <4150e5b8-b4c0-7151-d06e-a61d81eff97b@tarantool.org>
 <20200620212449.GB3503@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <9d73cfb2-99f5-1d1c-b337-3858b697c631@tarantool.org>
Date: Sun, 21 Jun 2020 17:35:50 +0200
MIME-Version: 1.0
In-Reply-To: <20200620212449.GB3503@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 2/2] box: reduce box_process_lua Lua
 GC memory usage
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

> diff --git a/src/box/lua/call.c b/src/box/lua/call.c
> index e1b1a5e81..e52f16ca4 100644
> --- a/src/box/lua/call.c
> +++ b/src/box/lua/call.c
> @@ -48,6 +48,15 @@
>  #include "mpstream/mpstream.h"
>  #include "box/session.h"
>  
> +/*

Please, change to /**. In out of function comments we use /**
as a comment start.

> + * Handlers identifiers to obtain lua_Cfunction reference from
> + * Lua registry table. These handlers are initialized on Tarantool
> + * startup and are used until the Lua universe is destroyed.
> + * Such approach reduces Lua GC usage since there is no need to
> + * create short-lived GCfunc objects for the corresponding C
> + * function on each iproto CALL/EVAL request or stored Lua
> + * procedure call.
> + */