From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 02FB64696C3 for ; Sat, 4 Apr 2020 23:51:50 +0300 (MSK) References: From: Vladislav Shpilevoy Message-ID: <9c596a06-603b-44f0-2687-d9b4d20bc826@tarantool.org> Date: Sat, 4 Apr 2020 22:51:49 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH v5 0/4] replication: fix local space tracking List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Petrenko , kostja.osipov@gmail.com Cc: tarantool-patches@dev.tarantool.org Hi! Thanks for the patchset! The branch has one failed job in Travis: https://travis-ci.org/github/tarantool/tarantool/jobs/668688927?utm_medium=notification&utm_source=github_status in replication-py/conflict.test.py. Can it be caused by these changes? On 30/03/2020 13:04, Serge Petrenko wrote: > https://github.com/tarantool/tarantool/issues/4114 > https://github.com/tarantool/tarantool/tree/sp/gh-4114-local-space-replication > > Changes in v5: > - review fixes as per review from Kostja > > Changes in v4: > - review fixes as per review from Kostja > > Changes in v3: > - rewrite the patches re wal gc rework > to avoid matrix clock. > > Changes in v2: > - used Georgy's patches re introduction of > matrix clock and wal gc rework to fix the > problem with ordering gc consumers by > vclock signature > > Serge Petrenko (4): > vclock: add an ability to reset individual clock components > replication: hide 0-th vclock components in replication responses > gc: rely on minimal vclock components instead of signatures > box: start counting local space requests separately > > src/box/applier.cc | 4 +- > src/box/box.cc | 29 +++- > src/box/gc.c | 41 +++--- > src/box/recovery.cc | 8 +- > src/box/relay.cc | 21 +-- > src/box/vclock.c | 15 +++ > src/box/vclock.h | 102 ++++++++++++++ > src/box/wal.c | 16 ++- > test/replication/anon.result | 5 + > test/replication/anon.test.lua | 2 + > test/replication/autobootstrap.result | 6 + > test/replication/autobootstrap.test.lua | 2 + > test/replication/before_replace.result | 8 +- > test/replication/before_replace.test.lua | 4 +- > .../gh-4114-local-space-replication.result | 125 ++++++++++++++++++ > .../gh-4114-local-space-replication.test.lua | 48 +++++++ > test/replication/local_spaces.result | 4 + > test/replication/local_spaces.test.lua | 3 + > test/replication/misc.result | 6 + > test/replication/misc.test.lua | 2 + > test/replication/quorum.result | 6 + > test/replication/quorum.test.lua | 2 + > test/replication/replica_rejoin.result | 9 ++ > test/replication/replica_rejoin.test.lua | 3 + > test/replication/skip_conflict_row.result | 3 + > test/replication/skip_conflict_row.test.lua | 1 + > test/replication/suite.cfg | 1 + > test/vinyl/errinj.result | 5 + > test/vinyl/errinj.test.lua | 4 + > 29 files changed, 442 insertions(+), 43 deletions(-) > create mode 100644 test/replication/gh-4114-local-space-replication.result > create mode 100644 test/replication/gh-4114-local-space-replication.test.lua >