From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 91F3626740 for ; Fri, 29 Jun 2018 07:27:14 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3XLy5os7L3W1 for ; Fri, 29 Jun 2018 07:27:14 -0400 (EDT) Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id ED05426726 for ; Fri, 29 Jun 2018 07:27:13 -0400 (EDT) Received: from [185.6.245.156] (port=58539 helo=msk-wire-v_shpilevoy-v.shpilevoy.mail.msk) by smtp29.i.mail.ru with esmtpa (envelope-from ) id 1fYrYV-0001At-Nz for tarantool-patches@freelists.org; Fri, 29 Jun 2018 14:27:11 +0300 Subject: [tarantool-patches] Re: [PATCH][vshard] Prohibit reconfigure non-dynamic options References: <20180615140225.2576-1-avkhatskevich@tarantool.org> <92d28edf-8237-c499-3ff0-e9795d8ff845@tarantool.org> <9d1392dc-c923-4e49-b3b5-41ad7d099ccd@tarantool.org> <161cd93f-0c72-181d-c9ab-23c9e8be1de3@tarantool.org> From: Vladislav Shpilevoy Message-ID: <9c50e20c-060c-2b2e-b1a4-a45d40cfc64e@tarantool.org> Date: Fri, 29 Jun 2018 14:27:11 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Thanks for the fixes! I have slightly refactored some of the tests and pushed the patch. 1. I updated a comment in rebalancer pin/lock test; 2. Removed now non-needed setting of bucket_count to 200 in a couple of tests. On 28/06/2018 14:06, Alex Khatskevich wrote: > It was decided verbally, that the bucket_cnt should be at least 3000 for stress tests, however it was 100 before the fixes > > 1. I have tried to separate stress tests from rebalancer tests, however they use a lot of common stuff and it is not a good approach to maintain 2 copies > > So, there are 2 branches: > > https://github.com/tarantool/vshard/tree/kh/gh-114-non-dynamic (bucket_count=3000) > https://github.com/tarantool/vshard/tree/kh/gh-114-non-dynamic-200 (200) > > Choose the one you like more >