From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B46B36EC58; Thu, 5 Aug 2021 00:20:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B46B36EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628112009; bh=BedAn5pyrmZqmsZASwT4rbelBTkknuju/sc2HWUcO0Y=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=DqB14XLfSvBavmTWxVJYZuuJMK827lwye3T1v3bLNFBHaARbmfDFLJDDUPtMG8caL WA3lxfV7WDq6AKp0XLMJqUflL3wm1/UnHtuqd+vShTQVG2KrJW5M5J6tILSxFWvMYt NmtYI8zVnrxNlgDPKwxNovMh65fFQj8+0zpO5/ms= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E12156EC58 for ; Thu, 5 Aug 2021 00:20:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E12156EC58 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1mBOJ3-0008D0-Oe; Thu, 05 Aug 2021 00:20:06 +0300 To: Vladimir Davydov Cc: tarantool-patches@dev.tarantool.org References: <903f6291-bab5-985e-f922-042453e4d146@tarantool.org> <20210804123001.3cwudybvkw6dds74@esperanza> Message-ID: <9c390b8d-cbbb-0aa3-b81b-a8e47a36ed09@tarantool.org> Date: Wed, 4 Aug 2021 23:20:04 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210804123001.3cwudybvkw6dds74@esperanza> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C36A98DBA789EBB6AE26DB9A6C1D9BF7E0182A05F538085040A9E3D0706410490995043859687C21766569A719264EFA95FF76AC6DA9FD7D1E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE71BDE6A359BD5B800EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375C4806A08D329A618638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8F3CA0E38CDD9D73247415EC92973672D117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC5FC25ED3FCEC3375A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352026055571C92BF10FCB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A45692FFBBD75A6A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5F267DC3FD4C123A4E45F3278D02335CD761498C41C6D9913D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34CC972AA0E2E780C45E913A800FAF48EE4AFD391AFBAF3653556CBD96F9EE441556C177C18FC900C81D7E09C32AA3244C01E4C6E8CC9DA379C275D8F88C39D093A995755A1445935E729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh4v93/7HD3UQeoEpJ1E7fg== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DF35DE0BB7D8F4559339301440ADE94633841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 15/20] net.box: rewrite request implementation in C X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" >>> +static int >>> +netbox_new_request(struct lua_State *L) >>> +{ >>> + struct netbox_request *request = lua_newuserdata(L, sizeof(*request)); >> >> 9. Does it help perf if the requests are allocated on mempool? > > I tried to allocate requests on mempool. To achieve that, we have to > turn them into C data. It resulted in a performance degradation, see the > parallel thread: It does not necessarily need to be cdata. You can use lua_newuserdata(L, sizeof(void *)) and store pointers at the requests which you allocate on mempool. The downside is that there will be +1 dereference for each access. The upside is that Lua might have optimizations for small userdata objects. For example, ffi.new() for objects < 128 bytes is order of magnitude faster than for bigger objects. Something similar might exist for userdata.