From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id DC5602A5F2 for ; Tue, 2 Apr 2019 04:28:42 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZEhzBibbVNKZ for ; Tue, 2 Apr 2019 04:28:42 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 88B512A4C3 for ; Tue, 2 Apr 2019 04:28:42 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v10 3/4] sql: create box.execute() References: <4b3ca18628a2ed3d0cbf70c4e0d0e6e182fa33ad.1554148476.git.v.shpilevoy@tarantool.org> <20190402081353.GK25072@chai> From: Vladislav Shpilevoy Message-ID: <9c02d676-8013-c71b-6b6d-270c57e5ec85@tarantool.org> Date: Tue, 2 Apr 2019 11:28:38 +0300 MIME-Version: 1.0 In-Reply-To: <20190402081353.GK25072@chai> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, Konstantin Osipov Cc: kyukhin@tarantool.org, imeevma@tarantool.org, Mergen Imeev On 02/04/2019 11:13, Konstantin Osipov wrote: > * Vladislav Shpilevoy [19/04/01 23:03]: >> + if (column_count > 0) { >> + lua_createtable(L, 0, 2); >> + lua_sql_get_description(stmt, L, column_count); >> + lua_setfield(L, -2, "metadata"); > > Could we rename lua_qsl_get_description() to > lua_sql_get_metadata() to be consistent in naming? No, we couldn't. Consistent naming is name the methods the same way, and box/execute.c uses term 'description', not 'metadata'. > > Otherwise LGTM. > > -- > Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 > http://tarantool.io - www.twitter.com/kostja_osipov >