From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id ED69A430D56
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 20 Nov 2019 01:50:44 +0300 (MSK)
References: <cover.1574091776.git.sergepetrenko@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <9bea3bba-ead8-490e-c9f5-aaf385c2637f@tarantool.org>
Date: Tue, 19 Nov 2019 23:57:11 +0100
MIME-Version: 1.0
In-Reply-To: <cover.1574091776.git.sergepetrenko@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v3 0/3] fiber.top(): minor fixup
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the fixes!

LGTM.

On 18/11/2019 17:05, Serge Petrenko wrote:
> The first patch factors all the clock-related members of struct fiber and struct
> cord into appropriate structs and adds methods for their updates and resets.
> 
> The second patch fixes exponential moving average calculation so that we do not
> experience huge numbers in average load percentage calculations.
> 
> The third patch alters fiber.top() test to wait for correct output before
> testing it. 
> 
> Follow-up https://github.com/tarantool/tarantool/issues/2694
> Branch https://github.com/tarantool/tarantool/tree/sp/gh-2694-test-fixup
> 
> Changes in v3:
>  - introduce a new patch which refactors all the clock stat
>    handling.
>  - introduce a patch fixing EMA calculation
>  - review fixes as per review from Vladislav
> 
> Changes in v2:
>  - clean up all fibers clock stats on fiber.top_enable()
>  - push 0 instead of NaN when cord clock_delta_last is 0
>  - review fixes as per review from Vladislav
> 
> Serge Petrenko (3):
>   fiber.top() refactor clock and cpu time calculation
>   fiber.top(): alter exponential moving average calculation
>   app/fiber: wait till a full event loop iteration ends
> 
>  src/lib/core/fiber.c    | 175 ++++++++++++++++++++++++----------------
>  src/lib/core/fiber.h    | 109 +++++++++++++++++--------
>  src/lua/fiber.c         |  20 +++--
>  test/app/fiber.result   |  38 ++++++---
>  test/app/fiber.test.lua |  36 +++++++--
>  5 files changed, 252 insertions(+), 126 deletions(-)
>