From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [94.100.177.104])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id B927D469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 19 Mar 2020 01:38:35 +0300 (MSK)
References: <c29d15e81d7df21df6bfa3f04bf58bcb987eee5f.1573596082.git.v.shpilevoy@tarantool.org>
 <27C6CB53-B660-4195-A09F-9B58EA089501@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <9ba81bc4-9ea3-65bd-41c2-924c1fb99881@tarantool.org>
Date: Wed, 18 Mar 2020 23:38:32 +0100
MIME-Version: 1.0
In-Reply-To: <27C6CB53-B660-4195-A09F-9B58EA089501@tarantool.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [Tarantool-patches] [PATCH 1/1] iproto: show real port in logs
 and box.info.listen
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Thanks for the review!

On 18/03/2020 19:18, Serge Petrenko wrote:
> Hi! Thanks for the patch!
> Alexander asked me to do the 2nd review.
> 
> The patch LGTM.
> 
> Sorry for nitpicking,  but looks like your changelog request has a typo in it:
>> @ChangeLog
>> - box.info.listen - new record in box.info <http://box.info>, which shows a
>>  real port when bound to port 0. For example, if box.cfg
>>  'listen' parameter was set to '127.0.0.1:0', box.info.listen
>>  will show '127.0.0.1:<real port > 0>' (gh-4620).
> just <real port>, without 0>, right?

Nope, I meant > 0. I wanted to emphasize, that the port is never
shown as 0 anymore. It is always some real port > 0.