From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6CA316EC40; Thu, 23 Sep 2021 01:48:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6CA316EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1632350898; bh=CpjrKwg3nXwyU+ZLeDPWQTTOjdc68e+UWZuX9GyvDfs=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=xbM1pZgKrhcpiMNS8KyTJ1i+paebjfnxaAuAB2CP5mHthL2OduHBSIwQT6w5kz0Xi 3ODmVWq5k9ec3XSZ6xQHPCHLq6uTh+KVOrSli+dYxKwpNvpwTJIVoGPPqvoL72IgEK 1qhKFdbdvUfoqAc8j4Hv4cPGKHwUlUdF9cD14+Fs= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7CEEB6EC40 for ; Thu, 23 Sep 2021 01:48:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7CEEB6EC40 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1mTB2E-00005q-Rs; Thu, 23 Sep 2021 01:48:15 +0300 To: imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <2db7d1a625d267ce15bcd1779b732bfdc4421694.1632220375.git.imeevma@gmail.com> Message-ID: <9b2da985-d8f1-306e-d442-5b13b1991bd5@tarantool.org> Date: Thu, 23 Sep 2021 00:48:13 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <2db7d1a625d267ce15bcd1779b732bfdc4421694.1632220375.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91AE02D33A9C88A2F5B11AABA1A86F90E3128B236C8D9319300894C459B0CD1B98CE582559FAF6D7CCFC6ABD59DE57855DC443D2BA0B873E570620434C0A4BCCF X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77603ADE015AF816DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063753275FB77F6A31628638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D819E247979A306645BD5534D4FEA034B6117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B613439FA09F3DCB32089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B505146249CD04DF8AE9BF0EF70651C41038 X-C1DE0DAB: 0D63561A33F958A54EEC3B46FF3F87BFCCF66FEE81EFA952B8D19C3556EB9EA7D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA759D2A03B9C34326B3410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D348B409C2D257583DFE17ADD6C418E96E338E21D942F8B61900886913FE3B98538E80EFA6BE26A55B11D7E09C32AA3244CC9C07D102B8A8C5BAA3CD763B678DDF5B018FE5BB746DCD1729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojYVPXnTWjYf7xwyrQffeY5w== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D884E5BDDC5430B5BC74D613C9E7AFF883841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 07/15] sql: rework SUM() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! > diff --git a/src/box/sql/func.c b/src/box/sql/func.c > index b4461c6ee..b06955302 100644 > --- a/src/box/sql/func.c > +++ b/src/box/sql/func.c > @@ -53,6 +53,29 @@ > static struct mh_strnptr_t *built_in_functions = NULL; > static struct func_sql_builtin **functions; > > +/** Implementation of the SUM() function. */ > +static void > +step_sum(struct sql_context *ctx, int argc, struct Mem **argv) > +{ > + assert(argc == 1); > + (void)argc; > + assert(ctx->pMem->type == MEM_TYPE_NULL || mem_is_num(ctx->pMem)); > + if (argv[0]->type == MEM_TYPE_NULL) Probably we should use mem_is_null() where possible. To avoid Mem members manual touch out of Mem.h and Mem.c. Here and in other places, other commits. Sorry I didn't notice it before.