From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 2722F44643A
 for <tarantool-patches@dev.tarantool.org>;
 Sun, 11 Oct 2020 18:25:29 +0300 (MSK)
References: <cover.1602420460.git.alexander.turenko@tarantool.org>
 <f1ee2349a4a1bc2a3c19af925e6e20d0cc7689ec.1602420460.git.alexander.turenko@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <9b2939cb-d2fe-e22d-41e4-0c653f04ddf7@tarantool.org>
Date: Sun, 11 Oct 2020 17:25:27 +0200
MIME-Version: 1.0
In-Reply-To: <f1ee2349a4a1bc2a3c19af925e6e20d0cc7689ec.1602420460.git.alexander.turenko@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v2 07/15] module api/lua: expose
 luaT_tuple_new()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Thanks for the patch!

See 1 comment below.

> diff --git a/src/box/lua/tuple.h b/src/box/lua/tuple.h
> index aadcf7f59..0c7e8a16f 100644
> --- a/src/box/lua/tuple.h
> +++ b/src/box/lua/tuple.h
> @@ -92,21 +92,35 @@ luaT_istuple(struct lua_State *L, int idx);
>   * should call <box_region_truncate>() to release the data.
>   *
>   * In case of an error set a diag and return NULL.
> + *
> + * @sa luaT_tuple_new()
>   */
>  API_EXPORT char *
>  luaT_tuple_encode(struct lua_State *L, int idx, size_t *tuple_len_ptr);
>  
> -/** \endcond public */
> -
>  /**
>   * Create a new tuple with specific format from a Lua table or a
>   * tuple.
>   *
> + * The new tuple is referenced in the same way as one created by
> + * <box_tuple_new>(). There are two possible usage scenarious:
> + *
> + * 1. A short living tuple may not be referenced explicitly and
> + *    will be collected automatically at the next module API call
> + *    that yields or returns a tuple.
> + * 2. A long living tuple must be referenced using
> + *    <box_tuple_ref>() and unreferenced than with

than -> then.