From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6AD306ECC0; Sat, 18 Dec 2021 16:58:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6AD306ECC0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1639835880; bh=V4rjj786RlChkePvD76p+HxeoHP0OoaqUFTO39syT6w=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=eY+HwF4qBmINVV1/enrKnUBppoDTwl/UXb2QAyFC98ZvB3dCOpD8RX9SOguRJtPGN SUosox4nzGD5+Eqi3kyOSfGUwvtTUOh26DCAWakhUCTCXniX15O6U5gpNWHvJ4SUz8 0+PJ7kJXvrrVFbgKNxpGZ8WwsuVRhFVyaWuwrS3E= Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B7E0D6ECC0 for ; Sat, 18 Dec 2021 16:57:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B7E0D6ECC0 Received: by smtp37.i.mail.ru with esmtpa (envelope-from ) id 1myaDm-0002GG-0b; Sat, 18 Dec 2021 16:57:58 +0300 Message-ID: <9b2851f1-dee5-a5b7-9e43-28687d155543@tarantool.org> Date: Sat, 18 Dec 2021 16:57:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org References: <9e5ff9cae03a55bf3cacc482449f19895360c80d.1639700518.git.v.shpilevoy@tarantool.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9B5397E24C93BDA6712610AD69032D75DE6A3E17E48EF72E3182A05F5380850406039AE5133AE55CB004BFC7D027CC72846D993B3EC8548F299CB1074828B1C0E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE701173C01F417A2A6EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375448D590B04CE87D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8B520CDD3CC91B86842EA5EFCA04365EC117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751F6FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE437C869540D2AB0FB341D7040ADD27A2D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3568FCE88E0C8489DAD7EC71F1DB88427C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637AF8E4F18C523FAA9EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A55A2892BF0D36E06AFBC80BE99C1F3AA52040FC0DB2A0215ED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA759D2A03B9C34326B3410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3458239C6F30CE7ACFE605D15CE8C6BAD9E43ACD5F2843904B0AD99C54834B9E78AED9DF5C3CA68EC41D7E09C32AA3244C8854E93E694BEFC28EF8D1DA5A453EC95A1673A01BA68E40729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojhDjsAWFBuTO0ZLnearIqCw== X-Mailru-Sender: 583F1D7ACE8F49BD1042885CEC987B6B0936007BA330A52C004BFC7D027CC7287CF96F699FB252597019711D9D5B048E1458020726E2BC9FD5ECBA0B92C0A936CDC7563AA7CEBD2872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH vshard 1/5] router: backoff on some box errors X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Oleg Babin via Tarantool-patches Reply-To: Oleg Babin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for your fixes. Yes, it is that I meant. LGTM. On 18.12.2021 02:10, Vladislav Shpilevoy wrote: > Hi! Thanks for the review! > > On 17.12.2021 12:09, Oleg Babin wrote: >> Thanks for your patch! LGTM. But I think tests should be extended a bit. >> >> I see that tests cover AccessDenied error but I don't see that there is simple error()/assert() error check. > I hope you meant this: > > ==================== > diff --git a/test/router/router2.result b/test/router/router2.result > index a501dbf..85d077a 100644 > --- a/test/router/router2.result > +++ b/test/router/router2.result > @@ -548,6 +548,28 @@ vshard.storage.call = old_storage_call > | --- > | ... > > +-- > +-- Fails without backoff for other errors. > +-- > +test_run:switch('router_1') > + | --- > + | - true > + | ... > +fiber.sleep(vshard.consts.REPLICA_BACKOFF_INTERVAL) > + | --- > + | ... > +rs = vshard.router.route(1) > + | --- > + | ... > +ok, err = rs:callro('vshard.storage.call', {1, 'badmode', 'echo', {100}}, \ > + long_timeout) > + | --- > + | ... > +assert(not ok and err.message:match('Unknown mode') ~= nil) > + | --- > + | - true > + | ... > + > _ = test_run:switch("default") > | --- > | ... > diff --git a/test/router/router2.test.lua b/test/router/router2.test.lua > index fb0c3b2..a2171fa 100644 > --- a/test/router/router2.test.lua > +++ b/test/router/router2.test.lua > @@ -216,6 +216,16 @@ test_run:switch('storage_2_a') > assert(echo_count == 0) > vshard.storage.call = old_storage_call > > +-- > +-- Fails without backoff for other errors. > +-- > +test_run:switch('router_1') > +fiber.sleep(vshard.consts.REPLICA_BACKOFF_INTERVAL) > +rs = vshard.router.route(1) > +ok, err = rs:callro('vshard.storage.call', {1, 'badmode', 'echo', {100}}, \ > + long_timeout) > +assert(not ok and err.message:match('Unknown mode') ~= nil) > + > _ = test_run:switch("default") > _ = test_run:cmd("stop server router_1") > _ = test_run:cmd("cleanup server router_1")