From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C19C96EC58; Wed, 4 Aug 2021 16:01:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C19C96EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628082070; bh=LmOclsdDSEMVaQs3mYaPW7tqpngGWJEQ3SOd8d9U1tw=; h=To:Cc:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=X5yGvXvAn4IKrZCzxqDVxYH66+lzCeGqNKDYl+nRIJaWynC0xlfxjTqp99/lsEJ33 ykQI5tdfyxWWW0LYcq9gtUujCZzTmCK9aA3DCUeq2jyS2564iYwIC7xetaXCI+JZKK MKdJO6iXV1+cHdy4v30hTrTit3csQ5n089PiNqoY= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5561F6EC5F for ; Wed, 4 Aug 2021 15:58:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5561F6EC5F Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1mBGTt-0000HP-LP; Wed, 04 Aug 2021 15:58:46 +0300 To: v.shpilevoy@tarantool.org Cc: tarantool-patches@dev.tarantool.org Date: Wed, 4 Aug 2021 15:58:45 +0300 Message-Id: <9addd684c79a460bbf20970f88e056cb18492465.1628081224.git.imeevma@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD941C43E597735A9C30A5AB0699C09BB51E5FD76225F0C99C3182A05F538085040D8787F1A541B0FBFD29C5AB6469E9DC30B05E4D24AEAF784D7B340DC787B6A11 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7E4A9B39A8BCE3A99EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063790B55F3E386DB9B28638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8A5AAE67FD567099C41142576F9AD40B0117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BAA867293B0326636D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B66F6A3E018CF4DC80089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: C20DE7B7AB408E4181F030C43753B8186998911F362727C414F749A5E30D975C30CE973C7F71088D54D5DE8A57A3BF49956FC03AEE48833A9C2B6934AE262D3EE7EAB7254005DCED7532B743992DF240BDC6A1CF3F042BAD6DF99611D93F60EF3033054805BDE987699F904B3F4130E343918A1A30D5E7FCCB5012B2E24CD356 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C2BE7381A0AD3DF18C66A1F551C8B7C6105D04505A38A80A9B1161BC1AF8F05C8FD6FB50141A3E041D7E09C32AA3244C7DB1418AC1CCC15241EB4C0C2C6FA75951E887DA02A9F7BF729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojeDyvyeZJDJFOowlH62VGzA== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D892FCB36B3BB446AA60852D49CEBCF5783D72C36FC87018B9F80AB2734326CD2FB559BB5D741EB96352A0ABBE4FDA4210A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: [Tarantool-patches] [PATCH v2 5/6] alter: disallow creation of SQL built-in function X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: imeevma@tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This patch prohibits creation of user-defined functions with SQL_BUILTIN engine. Closes #6106 --- src/box/alter.cc | 38 +++++++++++++++++++++++++++++++++++++ test/box/function1.result | 7 ++++++- test/box/function1.test.lua | 3 +++ 3 files changed, 47 insertions(+), 1 deletion(-) diff --git a/src/box/alter.cc b/src/box/alter.cc index 217b882ba..fd9921ae0 100644 --- a/src/box/alter.cc +++ b/src/box/alter.cc @@ -3213,6 +3213,36 @@ on_replace_dd_user(struct trigger * /* trigger */, void *event) return 0; } +/** + * Check if the version of the data dictionary is lower than 2.9.0 and return + * new func def if it is the case. If it is the case, then it is possible to + * insert values with the "SQL_BUILTIN" language into _func, otherwise it is + * prohibited. This is for upgradeability from 2.1.3 to 2.3.0. Since all we need + * is to allow such inserts, we set func def to its default values. + */ +static int +func_def_new_sql_built_in(struct func_def *def) +{ + if (dd_version_id >= version_id(2, 9, 0)) { + diag_set(ClientError, ER_FUNCTION_LANGUAGE, "SQL_BUILTIN", + def->name); + return -1; + } + def->body = NULL; + def->comment = NULL; + def->setuid = 1; + def->is_deterministic = false; + def->is_sandboxed = false; + def->param_count = 0; + def->returns = FIELD_TYPE_ANY; + def->aggregate = FUNC_AGGREGATE_NONE; + def->language = FUNC_LANGUAGE_LUA; + def->exports.lua = true; + def->exports.sql = true; + func_opts_create(&def->opts); + return 0; +} + /** * Get function identifiers from a tuple. * @@ -3344,6 +3374,14 @@ func_def_new_from_tuple(struct tuple *tuple) language, def->name); return NULL; } + if (def->language == FUNC_LANGUAGE_SQL_BUILTIN) { + if (func_def_new_sql_built_in(def) != 0) + return NULL; + if (func_def_check(def) != 0) + return NULL; + def_guard.is_active = false; + return def; + } } else { /* Lua is the default. */ def->language = FUNC_LANGUAGE_LUA; diff --git a/test/box/function1.result b/test/box/function1.result index a49a133f7..a1c89850d 100644 --- a/test/box/function1.result +++ b/test/box/function1.result @@ -372,7 +372,7 @@ c:close() box.schema.func.create('WAITFOR', {language = 'SQL_BUILTIN', \ param_list = {'integer'}, returns = 'integer',exports = {'SQL'}}) --- -- error: 'Failed to create function ''WAITFOR'': given built-in is not predefined' +- error: Unsupported language 'SQL_BUILTIN' specified for function 'WAITFOR' ... test_run:cmd("setopt delimiter ';'") --- @@ -1078,3 +1078,8 @@ box.func['test'].is_multikey == true box.func['test']:drop() --- ... +-- gh-6106: Check that user-defined functions cannot have SQL_BUILTIN engine. +box.schema.func.create("ABS", {language = 'SQL_BUILTIN', returns = 'integer'}) +--- +- error: Unsupported language 'SQL_BUILTIN' specified for function 'ABS' +... diff --git a/test/box/function1.test.lua b/test/box/function1.test.lua index 4fdd48520..e635b6e18 100644 --- a/test/box/function1.test.lua +++ b/test/box/function1.test.lua @@ -389,3 +389,6 @@ box.func.LUA:call({"return 1 + 1"}) box.schema.func.create('test', {body = "function(tuple) return tuple end", is_deterministic = true, opts = {is_multikey = true}}) box.func['test'].is_multikey == true box.func['test']:drop() + +-- gh-6106: Check that user-defined functions cannot have SQL_BUILTIN engine. +box.schema.func.create("ABS", {language = 'SQL_BUILTIN', returns = 'integer'}) -- 2.25.1