From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [tarantool-patches] Re: [PATCH v2 04/11] sio: make code compatible with C References: <20181205085723.d24pklnhvpybx37t@esperanza> From: Vladislav Shpilevoy Message-ID: <9a60d3b4-460f-1fbc-8f2f-ed8493bf7b9c@tarantool.org> Date: Wed, 5 Dec 2018 23:07:12 +0300 MIME-Version: 1.0 In-Reply-To: <20181205085723.d24pklnhvpybx37t@esperanza> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit To: tarantool-patches@freelists.org, Vladimir Davydov List-ID: On 05/12/2018 11:57, Vladimir Davydov wrote: > On Wed, Dec 05, 2018 at 12:28:51AM +0300, Vladislav Shpilevoy wrote: >> --- >> src/sio.cc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/sio.cc b/src/sio.cc >> index a13e7d9de..d0ae75dbc 100644 >> --- a/src/sio.cc >> +++ b/src/sio.cc >> @@ -355,7 +355,7 @@ sio_strfaddr(struct sockaddr *addr, socklen_t addrlen) >> static __thread char name[NI_MAXHOST + _POSIX_PATH_MAX + 2]; >> switch(addr->sa_family) { >> case AF_UNIX: >> - if (addrlen >= sizeof(sockaddr_un)) { >> + if (addrlen >= sizeof(struct sockaddr_un)) { >> snprintf(name, sizeof(name), "unix/:%s", >> ((struct sockaddr_un *)addr)->sun_path); >> } else { > > This doesn't deserve a separate patch. Squash it into patch 5 please. > No need to resend the patch. > Done on the branch.