From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4EFE056B396; Tue, 8 Aug 2023 11:26:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4EFE056B396 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1691483181; bh=SPaSusUlVZP1RQdglkq3Ba9o9KOzB4RFAq0J19Zhf70=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=OjMuxIEliVR0XbsvcA7OHXvF+JMlnmqIEFcjmmSBgW61JgElR7CxsZfg4Nt/K2kmt bs7FNFibkx46yLpCImQ4ItPIgF2wKPqrGHohAWWcBL7vq1xYWh3aQkfQHk6PvDpfMp qZ4m6WbLn2N4slumC263aAUWm9yHbXtsSTqw4EkE= Received: from smtp44.i.mail.ru (smtp44.i.mail.ru [95.163.41.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B1BA356A9A3 for ; Tue, 8 Aug 2023 11:26:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B1BA356A9A3 Received: by smtp44.i.mail.ru with esmtpa (envelope-from ) id 1qTI2k-003nAh-28; Tue, 08 Aug 2023 11:26:19 +0300 Message-ID: <9a4d18c4-9b0a-3022-3446-bc1c7bf52cb6@tarantool.org> Date: Tue, 8 Aug 2023 11:26:18 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Igor Munkin , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: <28b65ad39a0b6bd484e26e8baf9fd81979a267fa.1691415376.git.imun@tarantool.org> In-Reply-To: <28b65ad39a0b6bd484e26e8baf9fd81979a267fa.1691415376.git.imun@tarantool.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD969E04B5EED670DC836E8CADCCFC7EB90264FE23C7F795239182A05F5380850409AFEAB348114F442D8C609B036D0D05912633FE860E7F8270A6EA5BE8045C8AC X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE710FC7AC39A8009ECEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006377548186386978BE68638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8BAA05FBFAF7F3E7E52C6196CE6164B6A117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC47272755C61AA17BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520C24E1E72F37C03A06FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE9647ADFADE5905B1CAA9C333723BB66AD8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE34E7D9683544204AF6E0066C2D8992A16C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407978DA827A17800CE7649B83402744A6742DBA43225CD8A89FB26E97DCB74E625242539A7722CA490CB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A549640A176B2762D57881E9ADA33CAA8AF47370ED49A4725AF87CCE6106E1FC07E67D4AC08A07B9B0CE135D2742255B35CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFBFD6C247EF90988C6DC24DEF6BBBE31436DB5B546680244567F91981A5CAF854E4A5F4FEF661E8B51529AA6C8ABD04CA32A63C7A5D411B063399B38B0AAA7AE9E48CAC7CA610320002C26D483E81D6BE0DBAE6F56676BC7117BB6831D7356A2DEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj/xSHLV4ZQPu66Vt/diL9PA== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A76923040DBDF587F530D8C609B036D0D059C2EB5FBD3A89CC32EBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 16/15] gdb: fix Python statement usage X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" LGTM, thanks! On 8/7/23 16:41, Igor Munkin wrote: > This misuse was introduced in the initial implementation of GDB > extension within the commit 58790750b9c4bd4c21d883f109ab552a2e202a15 > ("gdb: introduce luajit-gdb extension") and also propagated to the > initial implementation of LLDB extension by copy-pasting in scope of the > commit 62fc84a8f89b8e5650162ba1c7696b0f84cf5c25 ("lldb: introduce > luajit-lldb"). However, is not a function, but statement, so > parenthesis around the condition are considered as a tuple constructor. > This patch simply removes the excess parenthesis to finally follow > Python semantics of the statement. > > Signed-off-by: Igor Munkin > --- > > **NB**: This patch will be placed before "[PATCH luajit 01/15] test: fix > E122 errors by pycodestyle" on the branch. > > CI: https://github.com/tarantool/luajit/actions/runs/5785962723/job/15679677849 > > src/luajit-gdb.py | 2 +- > src/luajit_lldb.py | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py > index 9075e99f..b7902d53 100644 > --- a/src/luajit-gdb.py > +++ b/src/luajit-gdb.py > @@ -327,7 +327,7 @@ def itypemap(o): > > > def funcproto(func): > - assert(func['ffid'] == 0) > + assert func['ffid'] == 0 > > return cast('GCproto *', > mref('char *', func['pc']) - gdb.lookup_type('GCproto').sizeof) > diff --git a/src/luajit_lldb.py b/src/luajit_lldb.py > index 85c0dcb9..94f54a59 100644 > --- a/src/luajit_lldb.py > +++ b/src/luajit_lldb.py > @@ -516,7 +516,7 @@ def strx64(val): > > > def funcproto(func): > - assert(func.ffid == 0) > + assert func.ffid == 0 > proto_size = sizeof('GCproto') > value = cast('uintptr_t', vtou64(mref('char *', func.pc)) - proto_size) > return cast(GCprotoPtr, value)