From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <k.sosnin@tarantool.org>
Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 3D239469719
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  2 Mar 2020 18:25:17 +0300 (MSK)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\))
From: Chris Sosnin <k.sosnin@tarantool.org>
In-Reply-To: <20200302105955.GA43956@tarantool.org>
Date: Mon, 2 Mar 2020 18:25:15 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <9E4E5772-52EF-456A-ACDA-1DEA067B0D55@tarantool.org>
References: <20200226161308.73170-1-k.sosnin@tarantool.org>
 <83fa4b26-3f6d-ce5c-56eb-4c2034004576@tarantool.org>
 <20200302105955.GA43956@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] sequence: return correct error on
 using dropped sequence
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi! Thank you for the review!

> 2 =D0=BC=D0=B0=D1=80=D1=82=D0=B0 2020 =D0=B3., =D0=B2 13:59, Nikita =
Pettik <korablev@tarantool.org> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB=
(=D0=B0):
>=20
> On 29 Feb 16:43, Vladislav Shpilevoy wrote:
>> LGTM.
>>=20
>> On 26/02/2020 17:13, Chris Sosnin wrote:
>>> This code is called from C, so it shouldn't throw.
>>>=20
>>> Closes #4753
>>> ---
>>> branch: =
https://github.com/tarantool/tarantool/tree/ksosnin/gh-4753-sequence-cpp-e=
xception=20
>>> issue: https://github.com/tarantool/tarantool/issues/4753
>>>=20
>=20
> Patch LGTM as well, but I see that 3 out of 4 runs on travis result in =
fail:
>=20
> =
https://travis-ci.org/tarantool/tarantool/builds/655369924?utm_source=3Dgi=
thub_status&utm_medium=3Dnotification
>=20
> Are these known failures (box/access etc)?
>=20

I didn=E2=80=99t rebase the patch, I=E2=80=99m sorry.
This branch doesn=E2=80=99t have the fix for Masha=E2=80=99s patch, =
where credentials for user weren=E2=80=99t dropped at the and of the =
test.
Will fix it.=