From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 3D39F43D679
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 31 Oct 2019 01:16:36 +0300 (MSK)
References: <20191029170219.GB29443@atlas>
 <20191029212006.23437-1-i.kosarev@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <99d1e77d-ad20-dad6-fb8b-1d7180bb4380@tarantool.org>
Date: Wed, 30 Oct 2019 23:22:09 +0100
MIME-Version: 1.0
In-Reply-To: <20191029212006.23437-1-i.kosarev@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v3] relay: fix join vclock
 obtainment in relay_initial_join
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Ilya Kosarev <i.kosarev@tarantool.org>, tarantool-patches@freelists.org
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the patch!

LGTM, except the comment below.

> diff --git a/src/box/wal.h b/src/box/wal.h
> index b76b0a41f..827b0fb85 100644
> --- a/src/box/wal.h
> +++ b/src/box/wal.h
> @@ -182,9 +182,10 @@ wal_mode();
>  /**
>   * Wait until all submitted writes are successfully flushed
>   * to disk. Returns 0 on success, -1 if write failed.
> + * Corresponding vclock is returned in @vclock unless it is NULL.
>   */

For parameter reference, please, use '@a <param_name>' syntax,
not '@<param_name>'. See doxygen documentation on @a.

>  int
> -wal_sync(void);
> +wal_sync(struct vclock *vclock);
>