From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E7E9E26F15
	for <tarantool-patches@freelists.org>; Fri,  8 Feb 2019 12:36:20 -0500 (EST)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id hXYGYfnsC1qm for <tarantool-patches@freelists.org>;
	Fri,  8 Feb 2019 12:36:20 -0500 (EST)
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9E3E226EC1
	for <tarantool-patches@freelists.org>; Fri,  8 Feb 2019 12:36:20 -0500 (EST)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: [tarantool-patches] Re: [PATCH v2 5/5] sql: introduce ALTER TABLE ADD
 CONSTRAINT UNIQUE/PRIMARY KEY
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <20190208171636.GF4588@chai>
Date: Fri, 8 Feb 2019 20:36:17 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <99FB42C6-1CA8-4E57-810A-16BDE6B1A7F4@tarantool.org>
References: <cover.1548265148.git.korablev@tarantool.org>
 <6dacbf399fb84152368b47576b42b4bc3da23e78.1548265148.git.korablev@tarantool.org>
 <20190208171636.GF4588@chai>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Konstantin Osipov <kostja@tarantool.org>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>



> On 8 Feb 2019, at 20:16, Konstantin Osipov <kostja@tarantool.org> =
wrote:
>=20
> * Nikita Pettik <korablev@tarantool.org> [19/01/23 21:03]:
>> +static void
>> +pk_check_existence(struct Parse *parse, uint32_t space_id, int =
_index_cursor)
>=20
> Tarantool function naming scheme is
> modulename-subject-verb-object.
>=20
> I applaud to an attempt to make the code follow Tarantool coding
> style, but please do follow it then.

I remember that I should fix this naming.
But firstly, I must deal with the first part of current patch-set.
When I get to the last commit, I will rename function to
=E2=80=9Cvdbe_emit_pk_existence_check=E2=80=9D or sort of
(hope module name is redundant since it is a static function).

>=20
> --=20
> Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
> http://tarantool.io - www.twitter.com/kostja_osipov
>=20