From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id BE65F246CB
	for <tarantool-patches@freelists.org>; Mon,  2 Jul 2018 14:30:25 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 9EY2FfGi3LOR for <tarantool-patches@freelists.org>;
	Mon,  2 Jul 2018 14:30:25 -0400 (EDT)
Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 7CA5E23CAC
	for <tarantool-patches@freelists.org>; Mon,  2 Jul 2018 14:30:25 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH] sql: remove support of partial
 indexes from parser
References: <20180702110824.28899-1-korablev@tarantool.org>
 <eb75a0d0-d34c-21b3-7c8a-58abccad381e@tarantool.org>
 <5F9DC699-08EE-4C3B-9491-114772B589B7@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <997f701a-3d2f-4a1b-4020-065214d335e4@tarantool.org>
Date: Mon, 2 Jul 2018 21:30:22 +0300
MIME-Version: 1.0
In-Reply-To: <5F9DC699-08EE-4C3B-9491-114772B589B7@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: "n.pettik" <korablev@tarantool.org>, tarantool-patches@freelists.org

LGTM.

On 02/07/2018 18:51, n.pettik wrote:
> 
>> 1. The error is caused by typo in the request, not by lack of
>> partial indexes.
> 
> Forgot to place ‘;’ at the end of statement:
> 
> @@ -291,14 +291,16 @@ test:do_eqp_test(
>           -- </index7-6.4>
>       })
>   
> +-- gh-2165 Currently, Tarantool lacks support of partial indexes,
> +-- so temporary we removed processing of their syntax from parser.
> +--
>   test:do_catchsql_test(
> -    "index7-6.5",
> +    "index7-7.1",
>       [[
> -        CREATE INDEX t5a ON t5(a) WHERE a=#1;
> +        CREATE TABLE t1 (a INTEGER PRIMARY KEY, b INTEGER);
> +        CREATE UNIQUE INDEX i ON t1 (a) WHERE a = 3;
>       ]], {
> -        -- <index7-6.5>
> -        1, [[near "#1": syntax error]]
> -        -- </index7-6.5>
> +        1, "keyword \"WHERE\" is reserved"
>