From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2F7B54696C3 for ; Tue, 7 Apr 2020 14:15:35 +0300 (MSK) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) From: Serge Petrenko In-Reply-To: <9c596a06-603b-44f0-2687-d9b4d20bc826@tarantool.org> Date: Tue, 7 Apr 2020 14:15:34 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <99625119-685F-4B8B-9594-2046999B8388@tarantool.org> References: <9c596a06-603b-44f0-2687-d9b4d20bc826@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v5 0/4] replication: fix local space tracking List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org > 4 =D0=B0=D0=BF=D1=80. 2020 =D0=B3., =D0=B2 23:51, Vladislav Shpilevoy = =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0= =B0): >=20 > Hi! Thanks for the patchset! >=20 > The branch has one failed job in Travis: > = https://travis-ci.org/github/tarantool/tarantool/jobs/668688927?utm_medium= =3Dnotification&utm_source=3Dgithub_status > in replication-py/conflict.test.py. Can it be caused > by these changes? Hi! Don=E2=80=99t think so. I couldn=E2=80=99t reproduce the failure on = my machine. >=20 > On 30/03/2020 13:04, Serge Petrenko wrote: >> https://github.com/tarantool/tarantool/issues/4114 >> = https://github.com/tarantool/tarantool/tree/sp/gh-4114-local-space-replica= tion >>=20 >> Changes in v5: >> - review fixes as per review from Kostja >>=20 >> Changes in v4: >> - review fixes as per review from Kostja >>=20 >> Changes in v3: >> - rewrite the patches re wal gc rework >> to avoid matrix clock. >>=20 >> Changes in v2: >> - used Georgy's patches re introduction of >> matrix clock and wal gc rework to fix the >> problem with ordering gc consumers by >> vclock signature >>=20 >> Serge Petrenko (4): >> vclock: add an ability to reset individual clock components >> replication: hide 0-th vclock components in replication responses >> gc: rely on minimal vclock components instead of signatures >> box: start counting local space requests separately >>=20 >> src/box/applier.cc | 4 +- >> src/box/box.cc | 29 +++- >> src/box/gc.c | 41 +++--- >> src/box/recovery.cc | 8 +- >> src/box/relay.cc | 21 +-- >> src/box/vclock.c | 15 +++ >> src/box/vclock.h | 102 ++++++++++++++ >> src/box/wal.c | 16 ++- >> test/replication/anon.result | 5 + >> test/replication/anon.test.lua | 2 + >> test/replication/autobootstrap.result | 6 + >> test/replication/autobootstrap.test.lua | 2 + >> test/replication/before_replace.result | 8 +- >> test/replication/before_replace.test.lua | 4 +- >> .../gh-4114-local-space-replication.result | 125 = ++++++++++++++++++ >> .../gh-4114-local-space-replication.test.lua | 48 +++++++ >> test/replication/local_spaces.result | 4 + >> test/replication/local_spaces.test.lua | 3 + >> test/replication/misc.result | 6 + >> test/replication/misc.test.lua | 2 + >> test/replication/quorum.result | 6 + >> test/replication/quorum.test.lua | 2 + >> test/replication/replica_rejoin.result | 9 ++ >> test/replication/replica_rejoin.test.lua | 3 + >> test/replication/skip_conflict_row.result | 3 + >> test/replication/skip_conflict_row.test.lua | 1 + >> test/replication/suite.cfg | 1 + >> test/vinyl/errinj.result | 5 + >> test/vinyl/errinj.test.lua | 4 + >> 29 files changed, 442 insertions(+), 43 deletions(-) >> create mode 100644 = test/replication/gh-4114-local-space-replication.result >> create mode 100644 = test/replication/gh-4114-local-space-replication.test.lua >>=20 -- Serge Petrenko sergepetrenko@tarantool.org